Skip to content

Comments

Remove ServiceWorkerMessageEvent; redirect to MessageEvent#14472

Merged
teoli2003 merged 1 commit intomdn:mainfrom
Elchi3:rm-swme
Mar 30, 2022
Merged

Remove ServiceWorkerMessageEvent; redirect to MessageEvent#14472
teoli2003 merged 1 commit intomdn:mainfrom
Elchi3:rm-swme

Conversation

@Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Mar 30, 2022

Since 2017 all browsers removed ServiceWorkerMessageEvent in favor of MessageEvent. We should delete and redirect.

See also https://chromestatus.com/feature/5014379292524544
BCD: mdn/browser-compat-data#15590

@Elchi3 Elchi3 requested review from a team as code owners March 30, 2022 15:22
@Elchi3 Elchi3 requested review from wbamberg and removed request for a team March 30, 2022 15:22
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Mar 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Preview URLs

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/55
Title: Firefox 55 for developers
on GitHub
Flaw count: 9

  • macros:
    • /en-US/docs/Web/CSS/linear-gradient redirects to /en-US/docs/Web/CSS/gradient/linear-gradient
    • /en-US/docs/Web/API/DOMString/href does not exist
    • /en-US/docs/Web/API/WindowProxy does not exist
    • /en-US/docs/Web/API/MediaKeySystemCapabilities does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Tools/Network_Monitor
    • Can't resolve /en-US/docs/Tools/Web_Console
    • Can't resolve /en-US/docs/Mozilla/Security/Security_and_the_jar_protocol
    • Can't resolve /en-US/docs/Mozilla/Firefox/Headless_mode
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/Audio_Channels_API

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub
Flaw count: 24

  • macros:
    • /en-US/docs/Web/CSS/-moz-math-display does not exist
    • /en-US/docs/Web/CSS/-moz-window-shadow does not exist
    • /en-US/docs/Web/CSS/@page/marks does not exist
    • /en-US/docs/Web/CSS/page does not exist
    • /en-US/docs/Web/CSS/size does not exist
    • and 11 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Tools/Memory
    • Can't resolve /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations
    • Can't resolve /en-US/docs/Tools/Performance/Waterfall#markers
    • Can't resolve /en-US/docs/Mozilla/Add-ons/Firefox_for_Android/API/Snackbars.jsm
    • Can't resolve /en-US/docs/Mozilla/Firefox_for_Android
    • and 3 more flaws omitted

URL: /en-US/docs/Web/API/Service_Worker_API
Title: Service Worker API
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/PeriodicSyncRegistration does not exist
    • /en-US/docs/Web/API/SyncRegistration does not exist

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/55
Title: Firefox 55 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/44
Title: Firefox 44 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Service_Worker_API
Title: Service Worker API
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

@teoli2003 teoli2003 merged commit 719cc61 into mdn:main Mar 30, 2022
@Elchi3 Elchi3 deleted the rm-swme branch March 30, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg was automatically assigned from mdn/yari-content-web-api

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elchi3 @teoli2003