Skip to content

Comments

Fix private methods link#14471

Merged
wbamberg merged 2 commits intomdn:mainfrom
Konrud:patch-19
Mar 30, 2022
Merged

Fix private methods link#14471
wbamberg merged 2 commits intomdn:mainfrom
Konrud:patch-19

Conversation

@Konrud
Copy link
Contributor

@Konrud Konrud commented Mar 30, 2022

Add / to the private methods link to make it work.

Add `/` to the private methods link to make it work.
@Konrud Konrud requested a review from a team as a code owner March 30, 2022 14:54
@Konrud Konrud requested review from wbamberg and removed request for a team March 30, 2022 14:54
@github-actions github-actions bot added the Content:JS JavaScript docs label Mar 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Closures
Title: Closures
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

External URLs

URL: /en-US/docs/Web/JavaScript/Closures
Title: Closures
on GitHub

No new external URLs

(this comment was updated 2022-03-30 15:21:13.299099)

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Konrud ! Just a typography suggestion.

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

@wbamberg wbamberg merged commit 10190da into mdn:main Mar 30, 2022
@wbamberg
Copy link
Collaborator

Thanks @Konrud for updating this old corner of the docs :)

@Konrud
Copy link
Contributor Author

Konrud commented Mar 30, 2022

Thanks @Konrud for updating this old corner of the docs :)

My pleasure. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:JS JavaScript docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants