Skip to content

Comments

Fix GitHub case when used as a word - nitpicking (part 2)#14457

Merged
wbamberg merged 1 commit intomdn:mainfrom
OnkarRuikar:onk-github
Mar 30, 2022
Merged

Fix GitHub case when used as a word - nitpicking (part 2)#14457
wbamberg merged 1 commit intomdn:mainfrom
OnkarRuikar:onk-github

Conversation

@OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Mar 30, 2022

Summary

Adding to #14400

Cases github -> GitHub were missed.

Metadata

  • Fixes a typo, bug, or other error

@OnkarRuikar OnkarRuikar requested review from a team as code owners March 30, 2022 04:11
@OnkarRuikar OnkarRuikar requested review from estelle, teoli2003 and wbamberg and removed request for a team March 30, 2022 04:11
@github-actions github-actions bot added Content:Learn Learning area docs Content:Learn:Django Learning area Django docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Mar 30, 2022
wbamberg
wbamberg approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @OnkarRuikar , this all looks good to me!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022

Preview URLs

Flaws

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Games/Techniques/3D_on_the_web/WebVR
Title: WebVR — Virtual Reality for the Web
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Detecting_device_orientation

URL: /en-US/docs/Web/Guide/Mobile/A_hybrid_approach
Title: A hybrid approach
on GitHub
Flaw count: 4

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/Guide/Mobile/Separate_sites
Title: Separate sites for mobile and desktop
on GitHub
Flaw count: 9

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/WebGL_API/WebGL_model_view_projection
Title: WebGL model view projection
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/BaseAudioContext/createScriptProcessor
Title: BaseAudioContext.createScriptProcessor()
on GitHub
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/HTML_text_fundamentals
Title: HTML text fundamentals
on GitHub
Flaw count: 8

  • macros:
    • /en-US/docs/Web/HTML/Element/h1 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h2 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h3 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h4 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • /en-US/docs/Web/HTML/Element/h5 redirects to /en-US/docs/Web/HTML/Element/Heading_Elements
    • and 2 more flaws omitted
  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_stores
Title: Working with Svelte stores
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
Title: Getting started with Ember
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Learn/JavaScript/Objects/Object-oriented_JS
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_deployment_next
Title: Deployment and next steps
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
Title: Deploying our app
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Introducing_complete_toolchain
Title: Introducing a complete toolchain
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Learn/CSS/CSS_layout/Flexbox
Title: Flexbox
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

External URLs

URL: /en-US/docs/Related/IMSC
Title: IMSC: subtitles and captioning for the Web
on GitHub

No new external URLs

URL: /en-US/docs/Related/IMSC/Using_the_imscJS_polyfill
Title: Using the imscJS polyfill
on GitHub

URL: /en-US/docs/Games/Techniques/3D_on_the_web/WebVR
Title: WebVR — Virtual Reality for the Web
on GitHub

URL: /en-US/docs/Web/Guide/Mobile/A_hybrid_approach
Title: A hybrid approach
on GitHub

URL: /en-US/docs/Web/Guide/Mobile/Separate_sites
Title: Separate sites for mobile and desktop
on GitHub

URL: /en-US/docs/Web/API/WebGL_API/WebGL_model_view_projection
Title: WebGL model view projection
on GitHub

URL: /en-US/docs/Web/API/IndexedDB_API/Checking_when_a_deadline_is_due
Title: Checking when a deadline is due
on GitHub

URL: /en-US/docs/Web/API/BaseAudioContext/createScriptProcessor
Title: BaseAudioContext.createScriptProcessor()
on GitHub

No new external URLs

URL: /en-US/docs/Learn/HTML/Introduction_to_HTML/HTML_text_fundamentals
Title: HTML text fundamentals
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_stores
Title: Working with Svelte stores
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Ember_getting_started
Title: Getting started with Ember
on GitHub

URL: /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_deployment_next
Title: Deployment and next steps
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
Title: Deploying our app
on GitHub

URL: /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Introducing_complete_toolchain
Title: Introducing a complete toolchain
on GitHub

No new external URLs

URL: /en-US/docs/Learn/Server-side/Django/Deployment
Title: Django Tutorial Part 11: Deploying Django to production
on GitHub

No new external URLs

URL: /en-US/docs/Learn/CSS/CSS_layout/Flexbox
Title: Flexbox
on GitHub

URL: /en-US/docs/MDN/Contribute/GitHub_beginners
Title: GitHub for complete beginners
on GitHub

No new external URLs

URL: /en-US/docs/MDN/Contribute/Howto/Write_an_API_reference
Title: How to write an API reference
on GitHub

@wbamberg wbamberg merged commit 7637345 into mdn:main Mar 30, 2022
@OnkarRuikar OnkarRuikar deleted the onk-github branch March 30, 2022 04:26
@ddbeck ddbeck removed the Content:Learn:Django Learning area Django docs label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbamberg wbamberg wbamberg approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 was automatically assigned from mdn/yari-content-http

@estelle estelle Awaiting requested review from estelle estelle was automatically assigned from mdn/yari-content-html

Assignees

No one assigned

Labels

Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OnkarRuikar @wbamberg @ddbeck