Conversation
`generateKey` returns a Promise. The variable names (`key` and `keyPair`) seem to indicate that these are actual values, but unawaited they are promises. Adding an await makes that more clear.
Contributor
Preview URLsFlawsURL:
External URLsURL: No new external URLs |
wbamberg
approved these changes
Mar 29, 2022
Collaborator
wbamberg
left a comment
wbamberg
left a comment
There was a problem hiding this comment.
👍 thank you @considine !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateKeyreturns a Promise. The variable names (keyandkeyPair) seem to indicate that these are actual values, but unawaited they are promises. Adding an await makes that more clear.Summary
I'm fixing the example code in the SubtleCrypto
generateKeydocs; this method returns a Promise, but the example snippets suggest (at least implicitly) that they resolve immediately.Motivation
It will help people reading the SubtleCrypto docs.
Supporting details
Related issues
Metadata