Skip to content

Comments

Add spaces inside inline braces#14439

Merged
wbamberg merged 1 commit intomainfrom
teoli2003-14438
Mar 29, 2022
Merged

Add spaces inside inline braces#14439
wbamberg merged 1 commit intomainfrom
teoli2003-14438

Conversation

@teoli2003
Copy link
Contributor

Fixes #14438

@teoli2003 teoli2003 requested a review from a team as a code owner March 29, 2022 17:43
@teoli2003 teoli2003 requested review from Elchi3 and removed request for a team March 29, 2022 17:43
@github-actions github-actions bot added the Content:JS JavaScript docs label Mar 29, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare
Title: String.prototype.localeCompare()
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Collator redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Collator/compare redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator/compare
    • /en-US/docs/Web/JavaScript/Reference/Global_Objects/Collator redirects to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Collator
  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Global_Objects/Collator/Collator

External URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/localeCompare
Title: String.prototype.localeCompare()
on GitHub

No new external URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this but I would much rather we put time into running Prettier than manually fix up style issues like this.

@wbamberg wbamberg merged commit 142b436 into main Mar 29, 2022
@wbamberg wbamberg deleted the teoli2003-14438 branch March 29, 2022 18:02
@wbamberg
Copy link
Collaborator

In fact wrt #14438, @ddbeck said:

  • We should work toward adopting Prettier to format code automatically and comprehensively. The first step toward that would be to adopt a Prettier config and check it in the repository. The process would culminate with full automated enforcement with CI.
  • Until that process is complete, we should cut down the JavaScript style guidelines to replace anything that Prettier could format with text saying, more or less, do whatever Prettier would do or configure your editor to do this.
  • In the mean time, we should reject any PRs that make style-only changes or any proposals to change the code style guidelines beyond what's already been described in this comment.

...and I agree with this plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:JS JavaScript docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content bug: Consistency of Style

2 participants