WebAPI: Clean syntax from property pages, part 1#14195
Merged
Conversation
Contributor
teoli2003
suggested changes
Mar 23, 2022
Co-authored-by: Jean-Yves Perrier <[email protected]>
OnkarRuikar
commented
Mar 23, 2022
Made `Value` level 2 header. Added missing Value sections.
OnkarRuikar
commented
Mar 23, 2022
Contributor
Author
|
@teoli2003 done! |
teoli2003
suggested changes
Mar 23, 2022
Contributor
teoli2003
left a comment
There was a problem hiding this comment.
Two small last changes and this is good to go. Thanks!
Co-authored-by: Jean-Yves Perrier <[email protected]>
Co-authored-by: Jean-Yves Perrier <[email protected]>
teoli2003
approved these changes
Mar 23, 2022
Contributor
|
Great! (And keep PRs more or less this size, so they can be reviewed fairly quickly) Thanks a lot! |
Contributor
Author
@teoli2003 There are ~1900 more to go, just for property pages. 🥴 |
Contributor
|
Perfect! And don't feel overcommitted! You can do what you want. If you want to stop, stop. If you want to restart, restart. Every bit helps. |
Contributor
Author
|
@teoli2003 I've automated this. 😊 |
Contributor
|
Yep. There are 5-6% of the cases that need manual work. |
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Mar 23, 2022
1 task
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Mar 24, 2022
Summary Sequel of mdn#14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
1 task
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Mar 24, 2022
@teoli2003 Summary Sequel of mdn#14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
teoli2003
pushed a commit
that referenced
this pull request
Mar 24, 2022
Summary Sequel of #14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Mar 25, 2022
@teoli2003 Summary Sequel of mdn#14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
1 task
hamishwillee
pushed a commit
that referenced
this pull request
Mar 25, 2022
@teoli2003 Summary Sequel of #14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
teoli2003
pushed a commit
that referenced
this pull request
Mar 25, 2022
@teoli2003 Summary Sequel of #14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Mar 26, 2022
@teoli2003 Summary Sequel of mdn#14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
This was referenced Mar 26, 2022
teoli2003
pushed a commit
that referenced
this pull request
Mar 26, 2022
* WebAPI: Clean syntax from property pages, part 7 @teoli2003 Summary Sequel of #14195 . As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft. * remove syntax section the file got left
1 task
OnkarRuikar
added a commit
to OnkarRuikar/content
that referenced
this pull request
Mar 28, 2022
Summary Sequel of mdn#14195 As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft. Changes: - Removed syntax sections - Enforced heading names to ## Value, ## Examples.
1 task
teoli2003
added a commit
that referenced
this pull request
Mar 28, 2022
* WebAPI: Clean syntax from property pages, part 10 Summary Sequel of #14195 As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft. Changes: - Removed syntax sections - Enforced heading names to ## Value, ## Examples. * Some more changes * added method `( )` in title * Apply suggestions from code review Co-authored-by: Jean-Yves Perrier <[email protected]> * moved getter and setters to Example section * Apply suggestions from code review Co-authored-by: Jean-Yves Perrier <[email protected]> Co-authored-by: Jean-Yves Perrier <[email protected]>
This was referenced Mar 29, 2022
This was referenced Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #14164
As instructed by @teoli2003 :
I've started working on property pages. This is first PR of many to come.
Motivation
As per the template API_property_subpage_template, Syntax section is redundant in property pages. So getting rid of the cruft.
Related issues
#14160
Metadata