Skip to content

Comments

MediaMetadata: fixed constructor section and marked experimental#14164

Merged
teoli2003 merged 1 commit intomdn:mainfrom
OnkarRuikar:patch-1
Mar 22, 2022
Merged

MediaMetadata: fixed constructor section and marked experimental#14164
teoli2003 merged 1 commit intomdn:mainfrom
OnkarRuikar:patch-1

Conversation

@OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar commented Mar 22, 2022

Summary

In #14160 we missed this interface to correct the possible constructor uses.
Also, marked Experimental as per BCD.

Metadata

  • Fixes a typo, bug, or other error

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner March 22, 2022 07:37
@OnkarRuikar OnkarRuikar requested review from jpmedley and removed request for a team March 22, 2022 07:37
@github-actions github-actions bot added the Content:WebAPI Web API docs label Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/API/MediaMetadata/MediaMetadata
Title: MediaMetadata()
on GitHub

No new external URLs

teoli2003
teoli2003 approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Once you are done with constructors, and if you still like this, you could adapt (by removing them) the syntax part of the properties. (See https://developer.mozilla.org/en-US/docs/MDN/Structures/Page_types/API_property_subpage_template) [Method syntax box also need some love] (There are many more occurrences of these than constructors)

@teoli2003 teoli2003 merged commit bdd39cc into mdn:main Mar 22, 2022
@OnkarRuikar OnkarRuikar deleted the patch-1 branch March 22, 2022 07:57
@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Mar 22, 2022 •
edited
Loading

[Method syntax box also need some love]

@teoli2003 by 'love' you mean remove the syntax sections completely from property description pages? 🤔

If there are more similar mass corrections then do let me know.

@teoli2003
Copy link
Contributor

teoli2003 commented Mar 22, 2022

Yes, I do mean this for properties, but that means having a good Value section instead (one that is clear).

@OnkarRuikar OnkarRuikar mentioned this pull request Mar 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley was automatically assigned from mdn/yari-content-web-api

1 more reviewer

@teoli2003 teoli2003 teoli2003 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Content:WebAPI Web API docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OnkarRuikar @teoli2003