Skip to content

Comments

New page: aria-modal#12559

Merged
estelle merged 11 commits intomdn:mainfrom
estelle:dialog
Jun 13, 2022
Merged

New page: aria-modal#12559
estelle merged 11 commits intomdn:mainfrom
estelle:dialog

Conversation

@estelle
Copy link
Member

@estelle estelle commented Feb 1, 2022

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@estelle estelle requested a review from a team as a code owner February 1, 2022 00:51
@estelle estelle requested review from ericwbailey and removed request for a team February 1, 2022 00:51
@github-actions github-actions bot added the Content:Accessibility Accessibility docs label Feb 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-modal
Title: aria-modal
on GitHub
Flaw count: 2

  • macros:
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.

External URLs

URL: /en-US/docs/Web/Accessibility/ARIA/Attributes/aria-modal
Title: aria-modal
on GitHub

(this comment was updated 2022-06-13 16:45:45.372881)

ericwbailey
ericwbailey suggested changes Feb 6, 2022
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and feedback here, again apologies for the late review.

@estelle estelle requested a review from ericwbailey February 10, 2022 20:34
ericwbailey
ericwbailey suggested changes Mar 1, 2022
View reviewed changes
ericwbailey
ericwbailey previously requested changes Mar 1, 2022
View reviewed changes
@estelle
Copy link
Member Author

estelle commented Apr 5, 2022

closes #14174

@estelle estelle linked an issue Apr 5, 2022 that may be closed by this pull request
aria-modal page not found #14174
Closed
@estelle estelle enabled auto-merge (squash) May 2, 2022 21:26
@estelle estelle requested a review from ericwbailey June 7, 2022 17:18
Rumyra
Rumyra requested changes Jun 13, 2022
View reviewed changes
@Rumyra
Copy link
Collaborator

Rumyra commented Jun 13, 2022

Just a few minor nits - but all in all once addressed happy for this to go through 👍

@Rumyra Rumyra dismissed ericwbailey’s stale review June 13, 2022 16:47

Only to enable merging

@estelle estelle merged commit c8ed891 into mdn:main Jun 13, 2022
@estelle estelle deleted the dialog branch July 19, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rumyra Rumyra Rumyra approved these changes

@ericwbailey ericwbailey Awaiting requested review from ericwbailey

Assignees

No one assigned

Labels

Content:Accessibility Accessibility docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aria-modal page not found

3 participants

@estelle @Rumyra @ericwbailey