Fix "auto" subsection link#123
Merged
chrisdavidmills merged 3 commits intomdn:mainfrom Nov 25, 2020
Merged
Conversation
The "auto" subsection didn't have an id attribute so the link was broken.
Contributor
|
Hi @gdsimoes ! So, by "the link", you're referring to the fragment link slightly above the values list? To be honest, I'd suggest that you fix this by just getting rid of the link, not adding an ID to the description term. We don't commonly have IDs in our property value lists like this, and the link is not really very useful — it's not as if the |
Instead of adding an id to the "auto" subsection I have removed the link.
Contributor
Author
|
Hello @chrisdavidmills ! I created a new commit to get rid of the link. As you might have guessed, I am a newbie at this so I don't know how to remove the previous commit. Should I create a new pull request? |
Contributor
|
Hi @gdsimoes ! Your update looks good. And no, you don't need to create a new pull request. Any further pushes you make to this existing pull request will update it's previous state, adding the new changes on top. So all you need to do now is remove the |
chrisdavidmills
requested changes
Nov 24, 2020
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
Change requested in above comment.
Contributor
Author
|
Hi @chrisdavidmills ! I removed the |
chrisdavidmills
approved these changes
Nov 25, 2020
Contributor
chrisdavidmills
left a comment
chrisdavidmills
left a comment
There was a problem hiding this comment.
That is perfect. Thanks so much for your contribution!
Merged
Closed
ricardotgomes11
added a commit
to ricardotgomes11/content
that referenced
this pull request
Sep 21, 2023
This is what it looks like in current engines. <!-- 🙌 Thanks for contributing to MDN Web Docs. Adding details below will help us to merge your PR faster. --> ### Description <!-- ✍️ Summarize your changes in one or two sentences --> ### Motivation <!-- ❓ Why are you making these changes and how do they help readers? --> ### Additional details <!-- 🔗 Link to release notes, vendor docs, bug trackers, source control, or other places providing more context --> ### Related issues and pull requests <!-- 🔨 If this fully resolves a GitHub issue, use "Fixes mdn#123" --> <!-- 👉 Highlight related pull requests using "Relates to mdn#123" --> <!-- ❗ If another pull request should be merged first, use "**Depends on:** mdn#123" --> <!-- 👷♀️ After submitting, go to the "Checks" tab of your PR for the build status -->
Cecil0o0
added a commit
to Cecil0o0/content
that referenced
this pull request
Feb 24, 2025
<!-- 🙌 Thanks for contributing to MDN Web Docs. Adding details below will help us to merge your PR faster. --> ### Description correct a little wrong usage ### Motivation <!-- ❓ Why are you making these changes and how do they help readers? --> ### Additional details <!-- 🔗 Link to release notes, vendor docs, bug trackers, source control, or other places providing more context --> ### Related issues and pull requests <!-- 🔨 If this fully resolves a GitHub issue, use "Fixes mdn#123" --> <!-- 👉 Highlight related pull requests using "Relates to mdn#123" --> <!-- ❗ If another pull request should be merged first, use "**Depends on:** mdn#123" --> <!-- 👷♀️ After submitting, go to the "Checks" tab of your PR for the build status -->
Josh-Cena
pushed a commit
that referenced
this pull request
Feb 24, 2025
Migrate HTML Interactive Examples (#38257) <!-- 🙌 Thanks for contributing to MDN Web Docs. Adding details below will help us to merge your PR faster. --> ### Description correct a little wrong usage ### Motivation <!-- ❓ Why are you making these changes and how do they help readers? --> ### Additional details <!-- 🔗 Link to release notes, vendor docs, bug trackers, source control, or other places providing more context --> ### Related issues and pull requests <!-- 🔨 If this fully resolves a GitHub issue, use "Fixes #123" --> <!-- 👉 Highlight related pull requests using "Relates to #123" --> <!-- ❗ If another pull request should be merged first, use "**Depends on:** #123" --> <!-- 👷♀️ After submitting, go to the "Checks" tab of your PR for the build status -->
cssinate
pushed a commit
to cssinate/content
that referenced
this pull request
Apr 11, 2025
Migrate HTML Interactive Examples (mdn#38257) <!-- 🙌 Thanks for contributing to MDN Web Docs. Adding details below will help us to merge your PR faster. --> ### Description correct a little wrong usage ### Motivation <!-- ❓ Why are you making these changes and how do they help readers? --> ### Additional details <!-- 🔗 Link to release notes, vendor docs, bug trackers, source control, or other places providing more context --> ### Related issues and pull requests <!-- 🔨 If this fully resolves a GitHub issue, use "Fixes mdn#123" --> <!-- 👉 Highlight related pull requests using "Relates to mdn#123" --> <!-- ❗ If another pull request should be merged first, use "**Depends on:** mdn#123" --> <!-- 👷♀️ After submitting, go to the "Checks" tab of your PR for the build status -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "auto" subsection didn't have an id attribute so the link was broken.