Skip to content

Comments

Update index.md adapting the module title#12029

Merged
wbamberg merged 5 commits intomdn:mainfrom
glmvc:patch-2
Mar 30, 2022
Merged

Update index.md adapting the module title#12029
wbamberg merged 5 commits intomdn:mainfrom
glmvc:patch-2

Conversation

@glmvc
Copy link
Contributor

@glmvc glmvc commented Jan 15, 2022

Summary

Adapted the module title (and slug) because the other modules in this course also always have "CSS" in front of them.

Motivation

I looked over the "overview pages" and noticed that little things differ - just for the sake of consistency of the pages...

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

Because the other modules in this course also always have "CSS" in front of them.
@glmvc glmvc requested a review from a team as a code owner January 15, 2022 10:03
@glmvc glmvc requested review from rachelandrew and removed request for a team January 15, 2022 10:03
@github-actions github-actions bot added the Content:Learn Learning area docs label Jan 15, 2022
@glmvc
Copy link
Contributor Author

glmvc commented Jan 15, 2022

Note: Changing the slug gives error because the folder name is still /Styling_text.

@wbamberg
Copy link
Collaborator

Thanks for this PR, @glmvc !

You need to use a special command for moving a document: https://github.com/mdn/content#moving-one-or-more-documents .

@glmvc
Copy link
Contributor Author

glmvc commented Jan 17, 2022

@wbamberg no problem, thank you for the reference! As soon as I'm a little more familiar with the git commands (and yarn), I'll make the change properly.

@glmvc
Copy link
Contributor Author

glmvc commented Feb 23, 2022

Thanks for this PR, @glmvc !

You need to use a special command for moving a document: https://github.com/mdn/content#moving-one-or-more-documents .

Hi @wbamberg,

After revisiting this pr and getting a little more comfortable with git etc, I noticed that the slug on the other CSS module pages doesn't start with CSS_ - except for the css layout module - check its index.md? That's why I thought the slug has to be changed...

But what they all have in common is the title that starts with "CSS".
I do not know now if only by changing the title, the text in the sidebar is also changed?
If so, I can undo the slug change and just change the title accordingly, right?
If not, is this an issue again with {{LearnSidebar}} like in Issue #5164?

I apologize for bothering and hope you can help me out - thanks in advance!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2022

@glmvc
Copy link
Contributor Author

glmvc commented Mar 17, 2022

@wbamberg Now I know (thanks to you) roughly how LearnSidebar works, thanks again.
So only the title had to be changed here. I'll make the change that affects the sidebar in another PR.

After revisiting this pr and getting a little more comfortable with git etc, I noticed that the slug on the other CSS module pages doesn't start with CSS_ - except for the css layout module - check its index.md? That's why I thought the slug has to be changed...

As already mentioned, the naming of the folder is different for the CSS layout module - i.e. the folder has "Css_" as a prefix.
I do not know now how high the priority on a uniform naming of the folders/documents is... Feel free to let me know if this needs to be changed.

@glmvc glmvc requested a review from a team as a code owner March 17, 2022 21:06
@glmvc glmvc requested review from dipikabh and removed request for a team March 17, 2022 21:06
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Mar 17, 2022
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be slow reviewing this one @glmvc ! Looks good to me.

@wbamberg wbamberg merged commit eaf00bd into mdn:main Mar 30, 2022
@glmvc glmvc deleted the patch-2 branch April 4, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs Content:Learn Learning area docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants