Skip to content

Comments

Delete for each...in error page#10793

Merged
Elchi3 merged 1 commit intomdn:mainfrom
wbamberg:delete-for-each-in-error-page
Nov 29, 2021
Merged

Delete for each...in error page#10793
Elchi3 merged 1 commit intomdn:mainfrom
wbamberg:delete-for-each-in-error-page

Conversation

@wbamberg
Copy link
Collaborator

@wbamberg wbamberg requested review from a team as code owners November 26, 2021 17:40
@wbamberg wbamberg requested review from sideshowbarker and removed request for a team November 26, 2021 17:40
@github-actions github-actions bot added the Content:JS JavaScript docs label Nov 26, 2021
@estelle
Copy link
Member

estelle commented Nov 26, 2021

The feature is still in use and browsers still support it. Should we not leave it in as a resource for when someone is reading old code?

@wbamberg
Copy link
Collaborator Author

The feature is still in use and browsers still support it. Should we not leave it in as a resource for when someone is reading old code?

At least the syntax in https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/For-each-in_loops_are_deprecated#examples doesn't work in Firefox or Chrome, so either that syntax is wrong or it is not supported in these browsers.

Also, this is not deleting the documentation page for for each...in - that page has already been deleted (I don't know when). This is deleting the page describing the warning you get when you try to use it. If it is true that Firefox and Chrome not longer support this feature, then they will never generate this error, so it doesn't seem worth documenting.

It's hard to find out exactly when support was removed, but this: https://stackoverflow.com/questions/4002879/javascript-for-each-with suggests that it was a long time ago, and that it was never supported in Chrome.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up, Will!

@Elchi3 Elchi3 merged commit b85fbf0 into mdn:main Nov 29, 2021
yin1999 added a commit to yin1999/translated-content that referenced this pull request Sep 1, 2022
yin1999 added a commit to mdn/translated-content that referenced this pull request Sep 1, 2022
* delete for each...in error page

ref: mdn/content#10793

* delete a TypeError page

* Removed obsolete page: sniffing animation support

ref: mdn/content#17290

* Duplicate Page Delete

ref: mdn/content#17765

* Delete Glossary/DHTML

ref: mdn/content#13138

* remove GlobalEventHandlers

ref: mdn/content#18778

* cleanup wikihistory
@wbamberg wbamberg deleted the delete-for-each-in-error-page branch October 15, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:JS JavaScript docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants