Mark link[as] Chrome support partial, with note#9578
Merged
Conversation
github-actions
Bot
added
the
data:html
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/loader/preload_helper.cc;l=135 indicates Blink doesn’t yet support `audio`, `video`, `document`, `embed`, `object`, `manifest`, `worker`, `sharedworker`, `audioworklet`, `paintworklet`, `report`, or `xslt` as values for the `as` attribute. So this change marks support in Chrome with partial_implementation:true, and a note listing the above `as` values as not supported. Fixes mdn#9577
sideshowbarker
force-pushed
the
sideshowbarker/link-rel-preload-partial-support
branch
from
ff419f7 to
50a724d
Compare
ddbeck
requested changes
Mar 25, 2021
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Some ideas on how to improve these notes. Thank you, @sideshowbarker!
Co-authored-by: Daniel D. Beck <[email protected]>
sideshowbarker
force-pushed
the
sideshowbarker/link-rel-preload-partial-support
branch
from
e2946d8 to
8c32d9c
Compare
Member
Author
@ddbeck Thanks much — committed those changes |
sideshowbarker
deleted the
sideshowbarker/link-rel-preload-partial-support
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/loader/preload_helper.cc;l=135 indicates Blink doesn’t yet support
audio,video,document,embed,object,manifest,worker,sharedworker,audioworklet,paintworklet,report, orxsltas values for theasattribute.So this change marks support in Chrome with partial_implementation:true, and a note listing the above
asvalues as not supported.Fixes #9577
This PR as currently scoped on updates the Chrome data for this.
I think Gecko and WebKit both also don’t support a number of of
asvalues, but I’m not sure it’s as easy to identify which values they don’t support as it is for Chrome.