Refactor: move compare-features script test out of linter#9229
Merged
queengooborg merged 3 commits intomdn:mainfrom Apr 19, 2022
bershanskiy:linter-refactor-testCompareFeatures
Merged
Refactor: move compare-features script test out of linter#9229queengooborg merged 3 commits intomdn:mainfrom bershanskiy:linter-refactor-testCompareFeatures
queengooborg merged 3 commits intomdn:mainfrom
bershanskiy:linter-refactor-testCompareFeatures
Conversation
5 tasks
Contributor
Author
|
@ddbeck Is this PR something you would be interested in reviewing eventually or was |
Contributor
Yes, I would like to review this! It's just… tough to find the time to do so. I'll see what I can do though. |
Contributor
Author
Of course, take your time. I'm just checking in to make sure this PR is still relevant. |
queengooborg
requested changes
Apr 18, 2022
Contributor
queengooborg
left a comment
There was a problem hiding this comment.
LGTM, just a little nit:
This was referenced Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves a unit test out of linter and into a separate mocha test file similar to
utils.test.js. This unit test is still called bynpm run test, sincetestscript includesnpm run mocha.For reviewer convenience, I split it up into two commits: the actual change is in the first commit and the second commit is just
npm run fix.Running
npm run testBefore:
After:
A checklist to help your pull request get merged faster: