Skip to content

[HOTFIX] Remove duplicate "width" feature from HTMLInputElement API#7751

Merged
queengooborg merged 1 commit intomdn:masterfrom
queengooborg:hotfix/HTMLInputElement-duplicate-width
Dec 14, 2020
Merged

[HOTFIX] Remove duplicate "width" feature from HTMLInputElement API#7751
queengooborg merged 1 commit intomdn:masterfrom
queengooborg:hotfix/HTMLInputElement-duplicate-width

Conversation

@queengooborg
Copy link
Copy Markdown
Contributor

Two PRs that were recently merged had both added a "width" feature to the HTMLInputElement API, causing a failure of the linter. This PR is a quick fix to remove the duplicate feature and combine the two entries.

Two PRs that were recently merged had both added a "width" feature to the HTMLInputElement API, causing a failure of the linter.  This PR is a quick fix to remove the duplicate feature and combine the two entries.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 14, 2020
@queengooborg queengooborg changed the title [HOTFIX] Remove duplicate "width" feature off HTMLInputElement API [HOTFIX] Remove duplicate "width" feature from HTMLInputElement API Dec 14, 2020
@queengooborg queengooborg merged commit c7ce24d into mdn:master Dec 14, 2020
@queengooborg queengooborg deleted the hotfix/HTMLInputElement-duplicate-width branch December 14, 2020 12:12
@queengooborg
Copy link
Copy Markdown
Contributor Author

Notice: Since this is a fix for a failing build in master, I merged this without review to resolve the build, though I know I'm technically not supposed to do that.

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Dec 14, 2020

Two PRs that were recently merged

@vinyldarkscratch Can you cite the PRs at issue here? And link to the failing actions? I'd like to understand the problem and the fix better.

@queengooborg
Copy link
Copy Markdown
Contributor Author

Of course! The two PRs are #7647 and #7671. Both of the PRs added the width feature for the HTMLInputElement API, but since the second of those PRs had performed a rename of a ghost feature (adding width in its place), Git didn't produce any merge conflicts, thus resulting in both PRs mergeable without issues.
https://github.com/mdn/browser-compat-data/runs/1550069646 (Admittedly, the linter's error message isn't too helpful, maybe we can create an update to the linter for it to catch and alert duplicates better?)

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Dec 14, 2020

Thanks, @vinyldarkscratch! Seems like an unusual case (two PRs against the same data, merged closely to each other). This doesn't happen terribly often (I can think of maybe one other case this year), so I'm OK with letting this fix be the end of it, unless this starts happening routinely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants