Add Chromium real values for MediaList API#7654
Merged
foolip merged 4 commits intomdn:masterfrom Dec 12, 2020
Merged
Conversation
This PR updates the Chromium data for the MediaList API based upon results from the mdn-bcd-collector project.
github-actions
bot
added
the
data:api
foolip
reviewed
Dec 11, 2020
api/MediaList.json
Outdated
| "support": { | ||
| "chrome": { | ||
| "version_added": true | ||
| "version_added": "44" |
Contributor
There was a problem hiding this comment.
I doubt this is right. http://mdn-bcd-collector.appspot.com/tests/api/MediaList doesn't involve an instance, and length is even more special than some other attributes.
A custom test could probably be added based on https://developer.mozilla.org/en-US/docs/Web/API/MediaList#Examples
foolip
reviewed
Dec 11, 2020
foolip
approved these changes
Dec 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Chromium data for the MediaList API based upon results from the mdn-bcd-collector project.