Update anchor and area support of target=_blank imply rel=noopener #7642
Merged
ddbeck merged 6 commits intomdn:masterfrom Dec 17, 2020
Merged
Update anchor and area support of target=_blank imply rel=noopener #7642ddbeck merged 6 commits intomdn:masterfrom
ddbeck merged 6 commits intomdn:masterfrom
Conversation
- [Chrome 88 supports it](https://bugs.chromium.org/p/chromium/issues/detail?id=898942) - [Safari 12.1 support it](https://developer.apple.com/documentation/safari-release-notes/safari-12_1-release-notes) Fix mdn#7324
- [Chrome 88 supports it](https://bugs.chromium.org/p/chromium/issues/detail?id=898942) - [Safari 12.1 support it](https://developer.apple.com/documentation/safari-release-notes/safari-12_1-release-notes) Fix mdn#7324
github-actions
bot
added
the
data:html
ddbeck
requested changes
Dec 14, 2020
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Hi @mems and thank you for this PR. I see this is your first to BCD—welcome to the project!
This change looks good, though it looks like this will make it to Edge 88 as well. Would you mind if we included Edge too? Line comments with suggestions.
Anchor and area target=_blank imply rel=noopener Co-authored-by: Daniel D. Beck <[email protected]>
Contributor
Author
|
Thanks @ddbeck. I've added the Edge version too as suggested. But the CI fail with the error: Look like it's related to #7751 |
Contributor
|
Apologies for the failing CI -- I've merged a quick fix to resolve the build failures! Can you do a quick merge of the latest |
Merge master
Contributor
Author
|
@vinyldarkscratch Done. Thanks that solve it. |
ddbeck
approved these changes
Dec 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7324
Change depreciated flag to false, it's now a recommendation.