Add missing features for HTMLEmbedElement#7586
Merged
foolip merged 5 commits intomdn:masterfrom Dec 12, 2020
Merged
Conversation
github-actions
bot
added
the
data:api
Contributor
|
@vinyldarkscratch can you go through this and see which are reflected content attributes and add/update the corresponding entries in embed.json? |
github-actions
bot
added
the
data:html
foolip
reviewed
Dec 10, 2020
| "deprecated": false | ||
| } | ||
| }, | ||
| "align": { |
Contributor
There was a problem hiding this comment.
Looks like content attribute entries are still missing for "align" and maybe other IDL attributes added here.
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
foolip
approved these changes
Dec 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of a project to add missing interfaces and interface features to BCD that are from a spec in Editor's Draft or more and is supported in at least one browser. This particular PR adds missing features for the HTMLEmbedElement API, populating the results using data from the mdn-bcd-collector project (v1.1.6).
Spec: https://html.spec.whatwg.org/multipage/iframe-embed-object.html#htmlembedelement
IDL: https://github.com/w3c/webref/blob/master/ed/idl/html.idl