Publish pre-build bundles to npm (idiomatic npm life cycle script)#7513
Closed
bershanskiy wants to merge 2 commits intomdn:mainfrom
bershanskiy:bundle-json
Closed
Publish pre-build bundles to npm (idiomatic npm life cycle script)#7513bershanskiy wants to merge 2 commits intomdn:mainfrom bershanskiy:bundle-json
bershanskiy wants to merge 2 commits intomdn:mainfrom
bershanskiy:bundle-json
Conversation
Background: #7374
5 tasks
Contributor
|
We decided to go the route of #7398, so I'm going to close this PR. Thank you this one too, @bershanskiy. It was genuinely instructive for landing the other PR. 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits up portion of #7398 to simplify review.
This PR does the following:
prepackscript that gets triggered automatically onnpm publish. This script creates data bundledist/data.jsonfor npm release.dist/index.jsthat automatically chooses betweenindex.js(for local development and testing) anddist/data.json(for downloads from npm)extendfrom actual dependency todevDependenciesbecause it's not needed after bundlingThis PR does not:
package.jsonpropertyenginesI'd really like to see
Where would we even plug tests with the limited flexibility of npm life cycle scripts? What would they test?
Background:
#7374
A checklist to help your pull request get merged faster: