Skip to content

Added Chrome Android version for prefer_related_applications#7386

Merged
ddbeck merged 3 commits intomdn:masterfrom
Yash-Singh1:patch-2
Dec 12, 2020
Merged

Added Chrome Android version for prefer_related_applications#7386
ddbeck merged 3 commits intomdn:masterfrom
Yash-Singh1:patch-2

Conversation

@Yash-Singh1
Copy link
Copy Markdown
Contributor

@Yash-Singh1 Yash-Singh1 commented Nov 17, 2020 •
edited
Loading

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any

Summary

Added Chrome version for prefer_related_applications

Data

Commits in the chromium repository show prefer_related_applications being used as early as Chrome 44:
chromium/chromium@51f7dbd

I searched through: https://github.com/chromium/chromium/search?o=asc&q=prefer_related_applications&s=indexed

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 17, 2020
@Yash-Singh1
Copy link
Copy Markdown
Contributor Author

Yash-Singh1 commented Nov 17, 2020

I think this should be labeled data:api

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Dec 10, 2020

Sorry for the long wait on reviewing this, @Yash-Singh1. I have a question about this change, however. Looking through some of the related bugs (this intent to ship provided a bunch of context), I'm not sure whether Chrome actually does anything with prefer_related_applications. Have you tried this out in a browser? Can you demonstrate what happens when a web developer uses this?

@Yash-Singh1
Copy link
Copy Markdown
Contributor Author

Yash-Singh1 commented Dec 10, 2020

@ddbeck I think the information that I added in is incorrect. In reality, Chrome for Android supported related_applications and prefers_related_applications on version 44+. There was an article about this: https://pracucci.com/chrome-related-applications.html. I will create a commit for this.

ddbeck
ddbeck approved these changes Dec 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @Yash-Singh1! That link was really helpful—there's a lot to corroborate this on Android.

@ddbeck ddbeck merged commit a539106 into mdn:master Dec 12, 2020
@Yash-Singh1 Yash-Singh1 changed the title Added Chrome version for prefer_related_applications Added Chrome Android version for prefer_related_applications Jan 26, 2021
@Woodpile37 Woodpile37 mentioned this pull request Aug 22, 2023
Merged
@ddbeck ddbeck mentioned this pull request Jul 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees

No one assigned

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yash-Singh1 @ddbeck