Merged
Conversation
github-actions
bot
added
the
data:html
ddbeck
requested changes
Nov 19, 2020
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Hi @web-padawan and welcome to BCD! Thank you for this PR. It looks good to me, but I have one suggestion, since I think this made its way to Android as well. Thank you!
Contributor
|
Hi @web-padawan, do you plan to come back to this PR? |
Co-authored-by: Daniel D. Beck <[email protected]>
Contributor
Author
|
@ddbeck Thank you, I missed your previous comment. Updated the PR based on your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark
exportpartsHTML attribute as supported since Firefox 72.Related issues for part forwarding are resolved & fixed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1559076
https://bugzilla.mozilla.org/show_bug.cgi?id=1594275