Remove notes about document.all being readonly#7012
Merged
sideshowbarker merged 1 commit intomdn:masterfrom Oct 22, 2020
Merged
Remove notes about document.all being readonly#7012sideshowbarker merged 1 commit intomdn:masterfrom
sideshowbarker merged 1 commit intomdn:masterfrom
Conversation
These notes were added in mdn#3391, after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/. Previously it was possible to assign document.all, and now it is not. The uses of document.all that currently work also work with older browsers, so there isn't anything that web developers need to be aware of here. The only time when it might have mattered was at the time of the change, if someone depending on being able to use document.all to store their own values, which in itself is an unlikely scenario.
github-actions
bot
added
the
data:api
sideshowbarker
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These notes were added in #3391,
after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/.
Previously it was possible to assign document.all, and now it is not.
The uses of document.all that currently work also work with older
browsers, so there isn't anything that web developers need to be aware
of here. The only time when it might have mattered was at the time of
the change, if someone depending on being able to use document.all to
store their own values, which in itself is an unlikely scenario.