Skip to content

Add tracking notes for never-supported CSS units#6925

Merged
ddbeck merged 5 commits intomdn:masterfrom
saschanaz:nosupport-cssunits
Nov 12, 2020
Merged

Add tracking notes for never-supported CSS units#6925
ddbeck merged 5 commits intomdn:masterfrom
saschanaz:nosupport-cssunits

Conversation

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Oct 15, 2020

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 15, 2020
@ddbeck ddbeck requested a review from rachelandrew November 6, 2020 11:26
rachelandrew
rachelandrew reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In values and units 4, I don't see a reason to remove.

@saschanaz saschanaz changed the title Remove never-supported CSS units Add tracking notes for never-supported CSS units Nov 9, 2020
saschanaz added a commit to saschanaz/browser-compat-data that referenced this pull request Nov 9, 2020
@saschanaz
Restore length units, will add notes in mdn#6925
e5b1d62
@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Nov 9, 2020
ddbeck
ddbeck approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @saschanaz and @rachelandrew! 🎉

@ddbeck ddbeck merged commit 52535d1 into mdn:master Nov 12, 2020
@saschanaz saschanaz deleted the nosupport-cssunits branch November 12, 2020 13:12
ddbeck pushed a commit that referenced this pull request Apr 8, 2021
@saschanaz
Add notes for never-supported CSS types (#6954)
f8eefd7 
* Remove never-supported CSS types
* Restore length units, will add notes in #6925
* Add notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachelandrew rachelandrew rachelandrew left review comments

@ddbeck ddbeck ddbeck approved these changes

Assignees

No one assigned

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschanaz @ddbeck @rachelandrew