Update Chrome data for Document features that were on HTMLDocument alias#6865
Merged
foolip merged 10 commits intomdn:masterfrom Oct 30, 2020
Merged
Update Chrome data for Document features that were on HTMLDocument alias#6865foolip merged 10 commits intomdn:masterfrom
foolip merged 10 commits intomdn:masterfrom
Conversation
github-actions
bot
added
the
data:api
queengooborg
added a commit
to queengooborg/browser-compat-data
that referenced
this pull request
Oct 8, 2020
foolip
reviewed
Oct 9, 2020
Contributor
|
@ddbeck I'd like your review on the note wording for this. |
foolip
reviewed
Oct 21, 2020
Contributor
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
The notes look good to me now, the only issue I can spot now is the Opera Presto ranges, which can probably all be collapsed.
Co-authored-by: Philip Jägenstedt <[email protected]>
foolip
reviewed
Oct 22, 2020
Contributor
|
Ping @vinyldarkscratch. If there's something tricky to resolve here, maybe we can split out those changes? |
foolip
approved these changes
Oct 30, 2020
Contributor
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I've done another lighter review, all looks good to me now!
| "notes": "Starting in Chrome 65, this property is readonly." | ||
| }, | ||
| { | ||
| "version_added": "3", |
Contributor
There was a problem hiding this comment.
document.all added in Chrome 3, interesting... I would have guessed it was older still.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Chromium data for various Document API features that were initially implemented via the
HTMLDocumentalias, first by obtaining the version numbers via the mdn-bcd-collector project, then separating them into sections withpartial_implementation. This is a cherry-pick from #6836, applying the review suggestions from #6836 (comment).