Add/update Chromium data for Window API#6838
Conversation
github-actions
bot
added
the
data:api
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I didn't review, just spotted cancelAnimationFrame and left that comment.
| @@ -972,10 +972,10 @@ | |||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/Window/cancelAnimationFrame", | |||
There was a problem hiding this comment.
Can you test for when the prefixed variants were added? They're included for requestAnimationFrame: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestAnimationFrame
Tests:
http://mdn-bcd-collector.appspot.com/tests/api/Window/webkitCancelAnimationFrame
http://mdn-bcd-collector.appspot.com/tests/api/Window/webkitCancelRequestAnimationFrame (after foolip/mdn-bcd-collector#601)
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
I've finished reviewing now. This is a big improvement, so I'll go ahead and back out the bits I'm not so sure about and merge what remains, to not risk getting conflicts and multiple roundtrips.
api/Window.json
Outdated
| "support": { | ||
| "chrome": { | ||
| "version_added": "37" | ||
| "version_added": "1" |
There was a problem hiding this comment.
This can't be right, window.crypto is newer than this. https://trac.webkit.org/changeset/78321/webkit is when it was added to WebKit, although there was something before that returning undefined with a "FIXME: Implement me" comment. I didn't check how that that was around for.
This also threw off results for Safari, so maybe we should do a custom test for window.crypto that ensures it exists and is an object at least?
There was a problem hiding this comment.
#6825 (comment) the other place we talked about this.
api/Window.json
Outdated
| "support": { | ||
| "chrome": { | ||
| "version_added": true | ||
| "version_added": "1" |
There was a problem hiding this comment.
window.external is a bit special, I think that for a long time it wasn't defined using Web IDL a bit like console. Have you checked what kind of thing it is in Chrome 1, was it an object with methods on it? I'm worried it might be a similar situation to window.crypto above.
| { | ||
| "version_added": true, | ||
| "version_added": "1", | ||
| "alternative_name": "pageXOffset" |
There was a problem hiding this comment.
This is api.Window.scrollX. I only noticed this now, but we also have a api.Window.pageXOffset entry, so these a alternative_name entries are weird, especially when both go back to ancient times. Can you clean that up in a separate PR?
|
@vinyldarkscratch I'll merge this now, but to avoid ambiguity these are the things I'm asking for post-merging:
|
This was all added in WebKit trunk 534.5 and 534.9: https://trac.webkit.org/changeset/64845/webkit https://trac.webkit.org/changeset/68252/webkit It wasn't enabled then, but because it all went together, it can all be assumed to match the ondevicemotion property being exposed. That was confirmed to be Chrome 31 with this test: http://mdn-bcd-collector.appspot.com/tests/api/Window/ondevicemotion The source of Chrome 11 is here: mdn#5834 The description says Chrome 31, so this must have been a copy-paste error from the IE version. Also update the Samsung Internet and WebView versions based on conservative mirroring. It's possible this was supported earlier, but the current version numbers also seem to be based on mirroring, not testing: mdn#6838
This was all added in WebKit trunk 534.5 and 534.9: https://trac.webkit.org/changeset/64845/webkit https://trac.webkit.org/changeset/68252/webkit It wasn't enabled then, but because it all went together, it can all be assumed to match the ondevicemotion property being exposed. That was confirmed to be Chrome 31 with this test: http://mdn-bcd-collector.appspot.com/tests/api/Window/ondevicemotion The source of Chrome 11 is here: #5834 The description says Chrome 31, so this must have been a copy-paste error from the IE version. Also update the Samsung Internet and WebView versions based on conservative mirroring. It's possible this was supported earlier, but the current version numbers also seem to be based on mirroring, not testing: #6838
This was all added in WebKit trunk 534.5 and 534.9: https://trac.webkit.org/changeset/64845/webkit https://trac.webkit.org/changeset/68252/webkit It wasn't enabled then, but because it all went together, it can all be assumed to match the ondevicemotion property being exposed. That was confirmed to be Chrome 31 with this test: http://mdn-bcd-collector.appspot.com/tests/api/Window/ondevicemotion The source of Chrome 11 is here: #5834 The description says Chrome 31, so this must have been a copy-paste error from the IE version. Also update the Samsung Internet and WebView versions based on conservative mirroring. It's possible this was supported earlier, but the current version numbers also seem to be based on mirroring, not testing: #6838
2 participants
This PR updates the Chromium data for the Window API based upon a combination of manual testing and collector results to achieve more real data for the Window API. (Note: most Opera updates have been deferred to #6837.)
Tests used: https://mdn-bcd-collector.appspot.com/tests/api/Window