Add/update Chromium data for Document API by queengooborg · Pull Request #6836 · mdn/browser-compat-data

queengooborg · 2020-10-05T17:36:25Z

This PR updates the Chromium data for the Document API based upon a combination of manual testing and collector results to achieve more real data for the Document API. (Note: most Opera updates have been deferred to #6835.)

Tests used: https://mdn-bcd-collector.appspot.com/tests/api/Document

api/Document.json

foolip

I reviewed this for a bit, but it's too big, changing something like 285 things. Can you split this alphabetically or something like that into at least 3 pieces, so it's more manageable to review?

api/Document.json

foolip · 2020-10-09T09:13:20Z

Thanks for trimming this, now I think it's small enough for me to review. Diving in!

foolip

A few changes requested here. I'll not revert bits and land directly in this case, since I'm not certain about every suggestion.

foolip · 2020-10-09T09:19:26Z

api/Document.json

          "support": {
            "chrome": {
-              "version_added": "43"
+              "version_added": "36"


I thought document.contentType was older than this, but it was added in https://chromium.googlesource.com/chromium/src/+/d0639256a9b3fa0dd01506742721ba44a502b24d so this checks out, date matches Chromium 36 in https://www.chromium.org/developers/calendar.

foolip · 2020-10-09T09:19:56Z

api/Document.json

+                "version_added": "23"
+              },
+              {
+                "version_added": "≤12.1",


This might just explain why it was an Opera employee who sent https://chromium.googlesource.com/chromium/src/+/d0639256a9b3fa0dd01506742721ba44a502b24d :)

foolip · 2020-10-09T09:24:49Z

api/Document.json

            "chrome": [
              {
-                "version_added": "45"
+                "version_added": "37"


(This is api.Document.exitPointerLock.) "45" came from #1324 so this is from the wiki, but I bet a lot of "45" are actually because https://omahaproxy.appspot.com/ can't handle commits before the Blink merge into Chromium. Happy to see these errors being sorted out.

https://caniuse.com/pointerlock agrees too. We're missing version_removed for the prefixed entry, but we'll discover that when mdn-bcd-collector coverage of prefixed stuff plus our updater improves.

foolip · 2020-10-09T10:09:08Z

api/Document.json

            "chrome": {
-              "version_added": false
+              "version_added": "1",
+              "version_removed": true


It was probably removed long ago, this is introducing uncertainty for what's in current Chrome. Can you either add the exact removal version or defer this change until later when it is known?

foolip · 2020-10-09T10:13:27Z

api/Document.json

+                "version_added": "58"
+              },
+              {
+                "version_added": "32",


The data that this is mirroring is wrong. document.onwebkitfullscreenchange was in Chrome 15 per http://mdn-bcd-collector.appspot.com/tests/api/Document/onwebkitfullscreenchange, probably earlier. Can you update the Chrome data for that, or just not mirror the incorrect data until it's fixed?

foolip · 2020-10-09T10:16:31Z

api/Document.json

-              }
-            ],
+            "chrome": {
+              "version_added": "62"


This seems much too new. I suspect a similar situation as in #6849, can you break out this change?

api/Document.json

foolip · 2020-10-09T10:20:01Z

api/Document.json

            },
            "edge": {
-              "version_added": false
+              "version_added": "85"


I thought Edge had shipped document.requestStorageAccess before Chrome, but maybe not. They were directly involved though: https://blogs.windows.com/msedgedev/2020/07/08/introducing-storage-access-api/

MS is driving the implementation in chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=989663

They enabled it to be on by default in Edge before Chrome but I can’t find any publicly source that indicates which Edge version it was enabled in 😿

api/Document.json

foolip · 2020-10-09T13:21:28Z

Actually, since this ends up blocking #6864 I will revert the bits I had comments on myself, and summarize needed follow-up in a comment.

- document.height/width - document.onwebkitfullscreenchange/error - document.onvisibilitychange - document.queryCommandIndeterm

foolip · 2020-10-09T15:05:13Z

Alright, merged. The required followup is simply the stuff reverted in 8dcd73f:

document.height/width
document.onwebkitfullscreenchange/error
document.onvisibilitychange
document.queryCommandIndeterm

…ias (#6865) This commit updates the Chromium data for various Document API features that were initially implemented on `HTMLDocument`, first by obtaining the version numbers via the mdn-bcd-collector project, then separating them into sections with `partial_implementation`. This is a cherry-pick from #6836, applying the review suggestions from #6836 (comment). Co-authored-by: Philip Jägenstedt <[email protected]>

It was implemented at the same time as the onreadystatechange event handler property in WebKit: https://trac.webkit.org/changeset/69710/webkit https://trac.webkit.org/browser/webkit/trunk/WebCore/Configurations/Version.xcconfig?rev=69710 The Chrome 9 data for onreadystatechange looks reliable: mdn#6836

It was implemented at the same time as the onreadystatechange event handler property in WebKit: https://trac.webkit.org/changeset/69710/webkit https://trac.webkit.org/browser/webkit/trunk/WebCore/Configurations/Version.xcconfig?rev=69710 The Chrome 9 data for onreadystatechange looks reliable: #6836

This PR adapts the pointerlockchange and pointerlockerror event of the Document API to conform to the new events structure. The data for Chromium was updated to adhere to the event handler data's changes in mdn#6836. Prefixed data was left alone.

#15230) This PR adapts the pointerlockchange and pointerlockerror event of the Document API to conform to the new events structure. The data for Chromium was updated to adhere to the event handler data's changes in #6836. Prefixed data was left alone.

Add/update Chromium data for Document API

336156f

github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 5, 2020

Merge branch 'master' into api/Document-chrome

da2c694

foolip reviewed Oct 8, 2020

View reviewed changes

api/Document.json Outdated Show resolved Hide resolved

Revert Safari changes

86b7335

foolip reviewed Oct 8, 2020

View reviewed changes

api/Document.json Outdated Show resolved Hide resolved

queengooborg mentioned this pull request Oct 8, 2020

Mirror Chrome -> Chromium Android for Document API #6864

Merged

Revert changes deferred to mdn#6864

f973854

queengooborg mentioned this pull request Oct 8, 2020

Update Chrome data for Document features that were on HTMLDocument alias #6865

Merged

Revert changes deferred to mdn#6865

76c4a95

foolip reviewed Oct 9, 2020

View reviewed changes

Revert changes based on own review

723f9ab

- document.height/width - document.onwebkitfullscreenchange/error - document.onvisibilitychange - document.queryCommandIndeterm

jokerface75 approved these changes Oct 9, 2020

View reviewed changes

foolip merged commit 8dcd73f into mdn:master Oct 9, 2020

queengooborg deleted the api/Document-chrome branch October 9, 2020 20:29

ddbeck mentioned this pull request Dec 9, 2020

Storage Access API data is not accurate #7510

Closed

andybons mentioned this pull request Dec 20, 2020

Update Storage Access API availability on Chrome #7661

Merged

foolip mentioned this pull request Nov 29, 2021

Update Chrome version for Document's readystatechange event #13793

Merged

queengooborg mentioned this pull request Mar 2, 2022

Adapt api.Document.onpointerlock[change/error] to new events structure #15230

Merged

Conversation

queengooborg commented Oct 5, 2020

Uh oh!

Uh oh!

foolip left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

foolip commented Oct 9, 2020

Uh oh!

foolip left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

foolip commented Oct 9, 2020

Uh oh!

foolip commented Oct 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants