Add linter for support blocks filled only with false#6809
Closed
Add linter for support blocks filled only with false#6809
Conversation
github-actions
bot
added
the
linter
This comment has been minimized.
This comment has been minimized.
saschanaz
changed the title
queengooborg
added
the
not ready
Contributor
|
Marking as "not ready" since we need to fix our data first. |
5 tasks
saschanaz
force-pushed
the
lint-nosupport
branch
from
8d2f8a5 to
61c8eeb
Compare
5 tasks
This was referenced May 22, 2021
Contributor
|
Could this be tweaked to test for falsy values to include null? That's the lint I think we should have :) |
Contributor
Author
|
We had way too many |
Contributor
|
That's a kind of progress! Would you mind updating what would still be failing this lint now? (I could, but am on phone but still curious...) |
Contributor
Author
|
Already did 😉 (I mean, #6854) |
Contributor
Author
Latest update. |
Contributor
|
Nice, a lot more bad data to sort through :) |
saschanaz
force-pushed
the
lint-nosupport
branch
from
ffae018 to
c566ebf
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Contributor
|
Hey @saschanaz, would you be down to update this? We've decided to proceed with disallowing all-false features in BCD! |
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
This was referenced Jul 11, 2022
Merged
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Contributor
Author
|
Found #16429 merged first with kinda similar purpose. Not sure what should I do, should I merge this with that one? This one seems to cover more things, at least. @queengooborg |
Contributor
Author
|
Okay, found #17743. Can you please ping me before such decision. |
Contributor
Author
|
Not sure how should I feel with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checklist to help your pull request get merged faster:
This implements a linter to prevent any support block filled only with
false.Quite a lot of failures, not sure how to proceed. Maybe create an allowlist for now and try reducing it later?