Skip to content

Add inputmode for Firefox Mobile#6468

Merged
ddbeck merged 1 commit intomdn:masterfrom
test137E29B:firefox-android-inputmode
Aug 18, 2020
Merged

Add inputmode for Firefox Mobile#6468
ddbeck merged 1 commit intomdn:masterfrom
test137E29B:firefox-android-inputmode

Conversation

@test137E29B
Copy link
Copy Markdown
Contributor

This adds data for Firefox Mobile's support of the inputmode attribute's usage as of Version 68, with a flag change.

Sourced from: https://caniuse.com/#feat=input-inputmode

Firefox mobile 68 supports this now with a flag change
@ghost ghost added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Aug 4, 2020
@evilpie
Copy link
Copy Markdown
Contributor

evilpie commented Aug 6, 2020

Shouldn't inputmode be shipping in the new Firefox for Android 79? https://bugzilla.mozilla.org/show_bug.cgi?id=1631681

@test137E29B
Copy link
Copy Markdown
Contributor Author

test137E29B commented Aug 7, 2020

Shouldn't inputmode be shipping in the new Firefox for Android 79? https://bugzilla.mozilla.org/show_bug.cgi?id=1631681

From the pushed changes, it would appear that it's simply defaulted true as of an upcoming version if the Version is Android, rather than using the flag like it currently does, though I'm not sure of the version. (See https://hg.mozilla.org/integration/autoland/rev/f98800d012f0)

There is currently no universal Firefox for Android version as the current is 68.11.0 on < Android 5, released end of July this year. 79 is the Desktop version, or Android 5+ which this change to the docs shouldn't affect.

Unsure if we should add both versions with a note pertaining to the Android OS Version.

@makotokato
Copy link
Copy Markdown
Contributor

See #4983 for Firefox/Android version. 79 is stable release and this attribute supports on 79, but I don't know whether this is ready for this data.

Copy link
Copy Markdown
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, though I have one suggestion. Thank you and welcome to BCD, @test137E29B.

],
"firefox_android": {
"version_added": false
"version_added": "68",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the feature in the desktop Firefox, I'm guessing this has been in the Android version for some time. Let's set this to true:

Suggested change
"version_added": "68",
"version_added": true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thank you @evilpie. I misunderstood the original PR description ("as of Version 68") to mean that it was tested in the current version and no others. I'll merge it as is.

@ddbeck ddbeck merged commit ef786ad into mdn:master Aug 18, 2020
@test137E29B test137E29B deleted the firefox-android-inputmode branch August 24, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants