Add missing preference info to playbackState#6465
Conversation
This follows up on my initial PR for playbackState in Firefox 80 by adding the missing information that you have to enable the preference to make it work. This is global across the entire API (kind of makes you wish you could do this in just one place), and I previously missed adding it here.
|
No, you're right: you should be able to do it in one place. Since the parent feature has the flag, you don't need to add one here. Really, the |
Does that actually work? I was under the impression that you had to include it on every item for it to show up on each page in the interface properly. |
|
Hmm, maybe this is an odd one. I'd appreciate @Elchi3's take here. Really, we need a guideline about this. I was under the impression that if a parent feature was gated behind a preference that we didn't need the preference on the subfeatures. Maybe it's a bit confusing in this case. Is it plausible that you'd use To actually answer your question, it works in the sense that the data is valid and makes sense. And it's easy to maintain: when A fake example: if you've got In terms of showing that on every page of an interface on MDN, I'd characterize this as yet another consumer-side issue, a problem with the way we generate tables. |
|
When displaying the data on MDN, we don't automatically inherit anything to the sub features, so flag information isn't inherited here either. We can discuss if we should implement such inheritance and what it does exactly. For BCD, think we added flags throughout, so tables look sensible for main features and for sub features. This practice is very MDN-rendering-driven, I'm not sure if it is the best for other data consumers. It seems we have no clear guideline, so that's a bug for the data model. |
|
So that means that what I've done here doesn't need changing after all. Thanks, @Elchi3. I do think we should look into the possibility of redefining things so that for members of an interface, the I thought about just allowing these to be left out to indicate "inherit" but that introduces ambiguity with the |
|
Anyway, @ddbeck, can you review when you have time? Thanks! :) |
|
I think we need to actually specify what we're doing here with flag data—the discussion here has made reviewing flag data a bit fraught. To that end, I've opened #6509. |
This follows up on my initial PR for playbackState in
Firefox 80 by adding the missing information that
you have to enable the preference to make it work.
This is global across the entire API (kind of makes
you wish you could do this in just one place), and
I previously missed adding it here.