Skip to content

adding data about implicit rel=noopener behavior#6366

Merged
ddbeck merged 2 commits intomdn:masterfrom
chrisdavidmills:implicit-noopener
Jul 6, 2020
Merged

adding data about implicit rel=noopener behavior#6366
ddbeck merged 2 commits intomdn:masterfrom
chrisdavidmills:implicit-noopener

Conversation

@chrisdavidmills
Copy link
Copy Markdown
Contributor

@ghost ghost added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jul 2, 2020
},
"implicit_noopener": {
"__compat": {
"description": "Setting <code>target=\"_blank\"</code> also provides implicit <code>rel=\"noopener\"</code> behavior",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this Chris. The data is good. I had a thought that the description could be a bit punchier, like this:

Suggested change
"description": "Setting <code>target=\"_blank\"</code> also provides implicit <code>rel=\"noopener\"</code> behavior",
"description": "<code>target=\"_blank\"</code> implies <code>rel=\"noopener\"</code> behavior",

Less wordy still would be this…

Suggested change
"description": "Setting <code>target=\"_blank\"</code> also provides implicit <code>rel=\"noopener\"</code> behavior",
"description": "<code>target=\"_blank\"</code> implies <code>rel=\"noopener\"</code>",

…but I'm not sure it's right: someElement.getAttribute("rel") === "noopener" but there's no actual rel="noopener" attribute. I'm not sure if that's a distinction without a difference. I'd be interested in your take.

@chrisdavidmills
Copy link
Copy Markdown
Contributor Author

@ddbeck thanks for the advice on wording. I've gone for the first one, as I think being more explicit is useful = it doesn't actually set the attribute, but it implies the behavior.

Copy link
Copy Markdown
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 19dbe03 into mdn:master Jul 6, 2020
@mkurz
Copy link
Copy Markdown
Contributor

mkurz commented Nov 7, 2020

@chrisdavidmills @ddbeck Starting with version 88, Chrome (and other chromium based browsers) will imply rel=noopener if anchor target=_blank, the corresponding issue just got closed: https://bugs.chromium.org/p/chromium/issues/detail?id=898942#c29 Can you update the data in BCD?

@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Nov 9, 2020

@mkurz I opened an issue, #7324, based on your comment. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants