Skip to content

Add "loading" attribute for img/iframe HTML elements#5442

Merged
Elchi3 merged 5 commits intomdn:masterfrom
queengooborg:html/loading-attr
Jan 9, 2020
Merged

Add "loading" attribute for img/iframe HTML elements#5442
Elchi3 merged 5 commits intomdn:masterfrom
queengooborg:html/loading-attr

Conversation

@queengooborg
Copy link
Copy Markdown
Contributor

Supersedes #5284 due to lack of response from the author. This PR adds the loading attribute to the <img> and <iframe>` elements, and fixes the linter errors within the original PR.

Enabled by default in Chrome 76: https://chromestatus.com/feature/5645767347798016
Bugzilla bug: https://bugzil.la/1542784 (seemingly only for <img>, thus only added to img.json)
Webkit bug: https://webkit.org/b/196698

@ghost ghost added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jan 3, 2020
@ddbeck
Copy link
Copy Markdown
Contributor

ddbeck commented Jan 3, 2020

Supersedes #5284 due to lack of response from the author

I don't think we need to roll this back, but just as a future reference, I think we should not be so quick to close unresponsive PRs during December and early January. Many of my European clients have been off work since the 20th (or earlier) and won't return until Monday, January 6 (or later). I would not be surprised if the author of the original PR never saw your requests for follow up.

@queengooborg
Copy link
Copy Markdown
Contributor Author

Ah, gotcha! I thought it would be reasonable to get a new PR since it’s been close to a month of no response, though I guess I got a bit overzealous. 😛

Copy link
Copy Markdown
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Daniel, we could have waited a bit here.
Let's get this in now though and hope that @Malvoz doesn't take it personally. 🙂
Great work everyone!

@Elchi3 Elchi3 merged commit 7d8de70 into mdn:master Jan 9, 2020
@queengooborg queengooborg deleted the html/loading-attr branch January 9, 2020 19:31
rachelandrew pushed a commit to rachelandrew/browser-compat-data that referenced this pull request Jan 9, 2020
* Update img.json with `loading` attr

* Update iframe.json with `loading` attr

* Update iframe.json

* Fix linter errors

Co-authored-by: Robert Linder <[email protected]>
@foolip
Copy link
Copy Markdown
Contributor

foolip commented Dec 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants