Add the loading attribute for <img> and <iframe>#5284
Closed
Malvoz wants to merge 3 commits intomdn:masterfrom
Closed
Add the loading attribute for <img> and <iframe>#5284Malvoz wants to merge 3 commits intomdn:masterfrom
loading attribute for <img> and <iframe>#5284Malvoz wants to merge 3 commits intomdn:masterfrom
Conversation
ghost
added
the
data:html
Contributor
|
Hey @Malvoz, thanks for your PR! Even though the CI says it passed, there's actually some issues (we made some changes to the linter that affected the return code). If you can rebase against the latest master and check the results of |
Contributor
|
Hey @Malvoz, do you plan to return to this PR? |
Contributor
|
Since we haven't heard back, I went ahead and made a new PR that fixes the linter errors. Thanks for getting the ball rolling! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental
loadingattribute, used to lazy-load (or force eager loading of)<img>and<iframe>.Enabled by default in Chrome 76:
https://chromestatus.com/feature/5645767347798016
Bugzilla bug: https://bugzil.la/1542784 (seemingly only for
<img>, thus only added the bug toimg.json)Webkit bug: https://webkit.org/b/196698
I'd be greatful if anyone can help me determine/confirm that the Webkit bug applies to both Safari and Safari iOS, as well as the Bugzilla bug applying to both Firefox and Firefox for Android.