Updates to document.all.#3391
Merged
Elchi3 merged 5 commits intomdn:masterfrom Feb 7, 2019
jpmedley:all
Merged
Conversation
Contributor
jpmedley
commented
Feb 5, 2019
- Chrome made this read only in Chrome 65. This is a bit confusing since it was previously marked 'readonly', but was also 'replaceable', which overrode.
- Document.all is not deprecated in the current spec. I can change it back if anyone knows something I don't.
Elchi3
requested changes
Feb 7, 2019
Member
Elchi3
left a comment
There was a problem hiding this comment.
Thanks for the PR. I'm not sure whether or not is deprecated. There are no MDN docs here, so no one has had an opinion about it yet, I guess?
There is a typo, and please remove the changes to package-lock.json
Co-Authored-By: jpmedley <[email protected]>
Co-Authored-By: jpmedley <[email protected]>
Co-Authored-By: jpmedley <[email protected]>
Contributor
Author
|
PTAL |
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Oct 22, 2020
These notes were added in mdn#3391, after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/. Previously it was possible to assign document.all, and now it is not. The uses of document.all that currently work also work with older browsers, so there isn't anything that web developers need to be aware of here. The only time when it might have mattered was at the time of the change, if someone depending on being able to use document.all to store their own values, which in itself is an unlikely scenario.
sideshowbarker
pushed a commit
that referenced
this pull request
Oct 22, 2020
These notes were added in #3391, after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/. Previously it was possible to assign document.all, and now it is not. The uses of document.all that currently work also work with older browsers, so there isn't anything that web developers need to be aware of here. The only time when it might have mattered was at the time of the change, if someone depending on being able to use document.all to store their own values, which in itself is an unlikely scenario.
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Oct 30, 2020
These notes were added in mdn#3391, after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/. Previously it was possible to assign document.all, and now it is not. The uses of document.all that currently work also work with older browsers, so there isn't anything that web developers need to be aware of here. The only time when it might have mattered was at the time of the change, if someone depending on being able to use document.all to store their own values, which in itself is an unlikely scenario.
ddbeck
pushed a commit
that referenced
this pull request
Nov 3, 2020
These notes were added in #3391, after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/. Previously it was possible to assign document.all, and now it is not. The uses of document.all that currently work also work with older browsers, so there isn't anything that web developers need to be aware of here. The only time when it might have mattered was at the time of the change, if someone depending on being able to use document.all to store their own values, which in itself is an unlikely scenario. See for additional background: #7193 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.