Skip to content

Updates to document.all.#3391

Merged
Elchi3 merged 5 commits intomdn:masterfrom
jpmedley:all
Feb 7, 2019
Merged

Updates to document.all.#3391
Elchi3 merged 5 commits intomdn:masterfrom
jpmedley:all

Conversation

@jpmedley
Copy link
Copy Markdown
Contributor

@jpmedley jpmedley commented Feb 5, 2019

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 6, 2019
Copy link
Copy Markdown
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'm not sure whether or not is deprecated. There are no MDN docs here, so no one has had an opinion about it yet, I guess?

There is a typo, and please remove the changes to package-lock.json

@jpmedley
Copy link
Copy Markdown
Contributor Author

jpmedley commented Feb 7, 2019

PTAL

Copy link
Copy Markdown
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Elchi3 Elchi3 merged commit 74d24d0 into mdn:master Feb 7, 2019
@jpmedley jpmedley deleted the all branch February 7, 2019 17:50
foolip added a commit to foolip/browser-compat-data that referenced this pull request Oct 22, 2020
These notes were added in mdn#3391,
after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/.

Previously it was possible to assign document.all, and now it is not.
The uses of document.all that currently work also work with older
browsers, so there isn't anything that web developers need to be aware
of here. The only time when it might have mattered was at the time of
the change, if someone depending on being able to use document.all to
store their own values, which in itself is an unlikely scenario.
sideshowbarker pushed a commit that referenced this pull request Oct 22, 2020
These notes were added in #3391,
after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/.

Previously it was possible to assign document.all, and now it is not.
The uses of document.all that currently work also work with older
browsers, so there isn't anything that web developers need to be aware
of here. The only time when it might have mattered was at the time of
the change, if someone depending on being able to use document.all to
store their own values, which in itself is an unlikely scenario.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Oct 30, 2020
These notes were added in mdn#3391,
after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/.

Previously it was possible to assign document.all, and now it is not.
The uses of document.all that currently work also work with older
browsers, so there isn't anything that web developers need to be aware
of here. The only time when it might have mattered was at the time of
the change, if someone depending on being able to use document.all to
store their own values, which in itself is an unlikely scenario.
ddbeck pushed a commit that referenced this pull request Nov 3, 2020
These notes were added in #3391,
after the change in https://chromium-review.googlesource.com/c/chromium/src/+/823513/.

Previously it was possible to assign document.all, and now it is not.
The uses of document.all that currently work also work with older
browsers, so there isn't anything that web developers need to be aware
of here. The only time when it might have mattered was at the time of
the change, if someone depending on being able to use document.all to
store their own values, which in itself is an unlikely scenario.

See for additional background: #7193 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants