Conversation
github-actions
bot
added
the
data:api
queengooborg
previously requested changes
Dec 1, 2024
Co-authored-by: Queen Vinyl Da.i'gyu-Kazotetsu <[email protected]>
skyclouds2001
commented
Jan 2, 2025
caugner
approved these changes
Jan 6, 2025
Contributor
caugner
left a comment
caugner
left a comment
There was a problem hiding this comment.
LGTM, thank you, just a typo.
caugner
changed the title
skyclouds2001
deleted the
node-performanceentry-performancemark-performancemeasure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
most performance related features has been exposed to global via nodejs/node#44483, in node v19.0.0
docs indicate that
PerformanceMarkandPerformanceMeasureis implemented in v18.2.0, v16.17.0, not v8.5.0docs changes happens in nodejs/node#44483
PerformanceMarkis implemented and can be accessed viaperf_hooksmodule in nodejs/node#37136, in v16.0.0PerformanceMeasureis implemented in nodejs/node#37136, in v16.0.0; bu can be accessed viaperf_hooksmodule in nodejs/node#39297, in v16.7.0manually test in local node instance:
so fired nodejs/node#55792 at node's repo
Test results and supporting details
https://nodejs.org/docs/latest/api/globals.html#performanceentry
https://nodejs.org/docs/latest/api/globals.html#performancemark
https://nodejs.org/docs/latest/api/globals.html#performancemeasure
https://nodejs.org/docs/latest/api/perf_hooks.html#class-performanceentry
https://nodejs.org/docs/latest/api/perf_hooks.html#class-performancemark
https://nodejs.org/docs/latest/api/perf_hooks.html#class-performancemeasure
Related issues