Merged
Conversation
github-actions
Bot
added
the
data:html
Merged
Elchi3
approved these changes
Apr 4, 2024
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks, I think it makes sense to copy the main preload values for these.
The idea here is to have data that differs for all future as= entries. This certainly is an improvement over marking the main preload feature as partial and mentioning all the unimplemented as= subfeatures in a note.
tunetheweb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add preload types as suggested in #22658 (review)
I'm not 100% sure when each of these
asvalues support was added and not sure there's an easy way to check so have just copied the mainpreloadvalues.Currently the only difference is
trackwhich is unsupported by Firefox.Test results and supporting details
https://wpt.fyi/results/preload?label=experimental&label=master&aligned
Related issues
Enhancement to #22658