Conversation
github-actions
Bot
added
the
data:html
Elchi3
approved these changes
Mar 27, 2024
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks, I think another option would be to have sub features for all of the preload types. For now, this seems good to me, though.
Contributor
Author
Good idea. Raised #22728 |
This was referenced Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chrome is noted as only having partial support as not supporting certain types (added in #9578) but this is actually true of all browsers so incorrect to label Chrome as only having partial support. See this example test as evidence. In fact Firefox supports one less type (
track) than Chrome (but raised).Our choices are:
I've chosen to go with the second option as browsers seem fairly consistent here and I don't think marking all as partial support is particularly helpful. But open to changing that if you think we should do the other way.
I've also NOT marked Firefox as having partial support as I think the lack of
tracksupport is a minor thing. I have added a note to that effect though.Test results and supporting details
See example here: https://resource-loading-examples.glitch.me/preload-types.html
(tested in Chrome 123, Firefox 123, and Safari 17.4)
Related issues
Content update here: mdn/content#32740
Also raised a spec discussion here: whatwg/html#8332 (comment)
And a caniuse request here: Fyrd/caniuse#7006