Combine SVGMatrix and WebKitCSSMatrix into DOMMatrix#18768
Combine SVGMatrix and WebKitCSSMatrix into DOMMatrix#18768queengooborg merged 4 commits intomdn:mainfrom
Conversation
github-actions
Bot
added
the
data:api
Elchi3
added
the
needs content update
queengooborg
removed
the
needs content update
| "support": { | ||
| "chrome": { | ||
| "version_added": "61" | ||
| "version_added": "2" |
There was a problem hiding this comment.
I don't think we should change the data for the constructor entry. Adding aliases that go back would be OK, and look just like the parent feature, but this data I would interpret as new DOMMatrix() being available since Chrome 2, which it isn't. The data isn't always shown with the parent feature after all:
https://developer.mozilla.org/docs/Web/API/DOMMatrix/DOMMatrix
|
Also, the twists and turns that finally led up to |
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Looks like we could mirror more, but approving so you can land after updating, if the change is to just mirror.
| "alternative_name": "WebKitCSSMatrix" | ||
| } | ||
| ], | ||
| "safari_ios": [ |
There was a problem hiding this comment.
Can we mirror here, or what's the difference if we do?
There was a problem hiding this comment.
There are some slight differences regarding Safari to Safari iOS mapping around there, so I'm skeptical about mirroring. (If the mirroring output was the same as what's currently shown, the linter would freak out and say we should use "mirror"!)
There was a problem hiding this comment.
Hmm, OK. Thanks for checking!
3 participants
This PR takes WebKitCSSMatrix and SVGMatrix and combines them into DOMMatrix. Both of these are defined as
LegacyWindowAliases in the IDL, and should not have separate files. (The subfeatures will probably need to be updated; a future collector version will help fix this.)Fixes #6726.