Skip to content

Remove release-level "accepts_flags" property from schema#15990

Merged
queengooborg merged 3 commits intomdn:mainfrom
queengooborg:schema/release-accepts-flags
Apr 25, 2022
Merged

Remove release-level "accepts_flags" property from schema#15990
queengooborg merged 3 commits intomdn:mainfrom
queengooborg:schema/release-accepts-flags

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Apr 23, 2022

This PR removes the release-level accepts_flags property from browser data from the schema. This property isn't used for linting and hasn't been adopted in browser data, as we already have a browser-wide accepts_flags statement.

Note: this can be included in a patch release as we have no data affected by this change.

@github-actions github-actions bot added the schema Isses or pull requests regarding the JSON schema files used in this project. label Apr 23, 2022
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but can you find the issue/PR that introduced this and post a comment that this bit is being reverted? Maybe someone had grand plans for this.

@github-actions github-actions bot added the docs Issues or pull requests regarding the documentation of this project. label Apr 24, 2022
@queengooborg
Copy link
Contributor Author

Done! This was added in by Daniel when adding the accepts_flags in general.

@queengooborg
Copy link
Contributor Author

Merging this since approval's been given!

@queengooborg queengooborg merged commit c1b7112 into mdn:main Apr 25, 2022
@queengooborg queengooborg deleted the schema/release-accepts-flags branch April 25, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Issues or pull requests regarding the documentation of this project. schema Isses or pull requests regarding the JSON schema files used in this project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants