Initial addition for Intl.Segmenter - Fixes #8894#14428
Merged
queengooborg merged 2 commits intomdn:mainfrom Jan 9, 2022
Merged
Initial addition for Intl.Segmenter - Fixes #8894#14428queengooborg merged 2 commits intomdn:mainfrom
queengooborg merged 2 commits intomdn:mainfrom
Conversation
github-actions
bot
added
the
data:js
queengooborg
approved these changes
Jan 9, 2022
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is looking good to me!
jpmedley
pushed a commit
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR intends to complete BCD data for ECMA402
Intl.SegmenterIt is also intended to be a companion of mdn/content#8402
This adds data for two objects
Intl.SegmenterandIntl.Segmentsas per mdn/content#8402 (comment)I completely admit I mimicked the target MDN structure to fill the data. Let me know if something should be added/adapted here.
Test results and supporting details
Chromium:
https://chromestatus.com/feature/6099397733515264#details
Deno:
https://deno.com/blog/v1.8#icu-support (could not find a more fine-grained detail) and tested locally for the latest version
Node:
I used the table on https://nodejs.org/en/download/releases/ to dtermine Node.js 16.0.0 was the first one with a V8 version > 8.7
Firefox:
https://bugzilla.mozilla.org/show_bug.cgi?id=1423593
WebKit:
https://trac.webkit.org/changeset/266032/webkit
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=266081 (closest revision of this file after 266032)
Safari 14.1 Release Notes https://developer.apple.com/documentation/safari-release-notes/safari-14_1-release-notes
Samsung Internet:
https://en.wikipedia.org/wiki/Samsung_Internet#cite_note-27 / https://medium.com/samsung-internet-dev/samsung-internet-releases-14-0-cf62d916193 (links to Chromium 87)
Opera:
Thanks for https://github.com/mdn/browser-compat-data/blob/main/browsers/opera_android.json and https://github.com/mdn/browser-compat-data/blob/main/browsers/opera.json :)
Related issues
Fixes #8894
Relates to mdn/content mdn/content#8402