Remove irrelevant KeyboardEvent.getModifierState parameters#12813
Merged
lucacasonato merged 1 commit intomdn:mainfrom Oct 12, 2021
Merged
Conversation
github-actions
bot
added
the
data:api
Contributor
|
@lucacasonato One thing I haven't well documented (so this is not a mistake on your part—it's mine): when reviewing PRs that remove a feature, check that the "needs-release-note" label is set, so I can write a note when preparing the release. You can also set it on anything else that looks like a candidate for a release note. (I double check for PRs that look like a removal when prepping the release—which is how I found this—so it's not a big deal if things slip through the cracks, but it's a nice-to-have for me. 😄) |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Oct 12, 2021
ddbeck
added a commit
that referenced
this pull request
Oct 12, 2021
* Bump version to v4.0.6 * Add release note for #12094 * Add release note for #12367 * Add release note for #12462 * Add release note for #12490 * Add release note for #12565 * Add release note for #12632 * Add release note for #12638 * Add release note for #12639 * Add release note for #12703 * Add release note for #12718 * Add release note for #12723 * Add release note for #12768 * Add release note for #12770 * Add release note for #12772 * Add release note for #12794 * Add release note for #12796 * Add release note for #12813 * Add stats and hoist known issues
Contributor
|
@ddbeck Sorry, will do next time! Thanks for the heads up 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the four irrelevant parameters for the
getModifierStatemethod of theKeyboardEventAPI. These rows are all false except for IE, though I suspect its support to also be false. (Not that it matters, since Edge is marked asfalsemeaning this falls under the irrelevant features removal guideline.)