Remove unsupported Window.dialogArguments#12704
Conversation
github-actions
bot
added
the
data:api
| } | ||
| } | ||
| }, | ||
| "dialogArguments": { |
There was a problem hiding this comment.
IE, Safari and Firefox had window.dialogArguments
There was a problem hiding this comment.
Should we have the same compat info as showModalDialog here? https://developer.mozilla.org/en-US/docs/Web/API/Window/showModalDialog#browser_compatibility
There was a problem hiding this comment.
If the removal of showModalDialog was accompanied by the removal of dialogArguments, maybe yes.
But like I said Firefox supported dialogArguments hence the table would be erroneous.
e.g. Firefox 3.6 does
Someone with access to a browser farm will have to test it out.
queengooborg
added
needs content update
|
I opened mdn/content#10694 for Window.setCursor removal. |
|
If |
|
Only the |
foolip
changed the title
|
I've dug into main.html: <!doctype html>
<button>open dialog</button>
<script>
document.querySelector('button').onclick = function() {
var value = window.showModalDialog('dialog.html', ['hello', 'world']);
alert('returned value: ' + value);
};
</script>dialog.html: <!doctype html>
<div></div>
<script>
document.querySelector('div').textContent = JSON.stringify(window.dialogArguments);
</script>
<button>close me</button>
<script>
document.querySelector('button').onclick = function() {
window.returnValue = 42;
window.close();
};
</script>Running this in Safari 15.4 shows that it still works, both However, these are not normal properties of window that always exist, rather the I think we should either have MDN pages + compat data for both |
Sounds good to me! |
queengooborg
removed
the
needs content update
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
The MDN content updates have been merged now, so this PR is ready to go!
5 participants
Summary
Test results and supporting details
Related issues
#6854