Merged
Conversation
github-actions
bot
added
dependencies
Contributor
queengooborg
approved these changes
Oct 1, 2021
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
Thanks for tackling this @ddbeck, this is looking great to me!
Elchi3
approved these changes
Oct 12, 2021
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks Daniel, this all makes sense to me. Glad to see tests 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hamishwillee got an unexpected consistency failure with
"preview"values. This PR adds some handling to remove it.Test results and supporting details
See #12194 (comment) for a test case.
You can also check out the first commit on this branch (5525c22) to see the tests fail, then check out the head to make them turn green.