Skip to content

Comments

Remove irrelevant MouseWheelEvent API#12565

Merged
queengooborg merged 1 commit intomdn:mainfrom
queengooborg:api/MouseWheelEvent/removal
Sep 28, 2021
Merged

Remove irrelevant MouseWheelEvent API#12565
queengooborg merged 1 commit intomdn:mainfrom
queengooborg:api/MouseWheelEvent/removal

Conversation

@queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Sep 24, 2021

This PR removes the irrelevant MouseWheelEvent API as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v3.3.0), even if the current BCD suggests support. I've also manually confirmed a lack of support by checking Chrome's and Safari's sources, and checked Edge for compatibility.

This PR removes the irrelevant `MouseWheelEvent` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.3.0), even if the current BCD suggests support.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Sep 24, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 24, 2021
@foolip
Copy link
Contributor

foolip commented Sep 24, 2021

Was this in Edge 18? If so it's still too early to remove per guideline.

@queengooborg
Copy link
Contributor Author

It was not in Edge 18, I did check that!

@foolip
Copy link
Contributor

foolip commented Sep 25, 2021

Excellent!

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging, please land the MDN change first.

@hamishwillee
Copy link
Contributor

What about the associated event https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onmousewheel ?

Even though we redirect, could you clean up some of the internal links? e.g.

might be simple enough just to turn them from links to code-only.

@queengooborg
Copy link
Contributor Author

I've opened a follow-up PR to the content repo! I'll go ahead and merge this since the main removal is complete.

@queengooborg queengooborg merged commit 9b9b4f7 into mdn:main Sep 28, 2021
@queengooborg queengooborg deleted the api/MouseWheelEvent/removal branch September 28, 2021 13:11
@ddbeck
Copy link
Contributor

ddbeck commented Oct 12, 2021

I've opened a follow-up PR to the content repo! I'll go ahead and merge this since the main removal is complete.

@queengooborg could you link to the corresponding content PR? It's not clear to me that the needs-content-update label was satisfied before merging.

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 12, 2021
ddbeck added a commit that referenced this pull request Oct 12, 2021
* Bump version to v4.0.6

* Add release note for #12094

* Add release note for #12367

* Add release note for #12462

* Add release note for #12490

* Add release note for #12565

* Add release note for #12632

* Add release note for #12638

* Add release note for #12639

* Add release note for #12703

* Add release note for #12718

* Add release note for #12723

* Add release note for #12768

* Add release note for #12770

* Add release note for #12772

* Add release note for #12794

* Add release note for #12796

* Add release note for #12813

* Add stats and hoist known issues
@queengooborg
Copy link
Contributor Author

Certainly! The removal was done in mdn/content#9244, which had satisfied the content updates for us to be able to remove this feature. Follow-up cleanup was then done in mdn/content#9319.

@ddbeck ddbeck removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants