Remove ScrollToOptions dictionary; fix scroll options data#12490
Merged
Remove ScrollToOptions dictionary; fix scroll options data#12490
Conversation
github-actions
bot
added
the
data:api
queengooborg
added
needs content update
This was referenced Sep 20, 2021
Contributor
|
I've written http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9636 to test for support with feature detection. Can you double check data that was based on commit dates using this? It's hard to tell if there are any runtime flags involved here. |
queengooborg
removed
the
needs content update
foolip
requested changes
Sep 21, 2021
Contributor
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
Trying to verify revealed some errors. After applying fixes, can you check if all of the entries have the exact same data? I would expect only two variants of the data due to the different versions for behavior and top/left in Safari, but everything else to stay the same across the board.
foolip
approved these changes
Sep 24, 2021
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Oct 12, 2021
ddbeck
added a commit
that referenced
this pull request
Oct 12, 2021
* Bump version to v4.0.6 * Add release note for #12094 * Add release note for #12367 * Add release note for #12462 * Add release note for #12490 * Add release note for #12565 * Add release note for #12632 * Add release note for #12638 * Add release note for #12639 * Add release note for #12703 * Add release note for #12718 * Add release note for #12723 * Add release note for #12768 * Add release note for #12770 * Add release note for #12772 * Add release note for #12794 * Add release note for #12796 * Add release note for #12813 * Add stats and hoist known issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR performs two actions related to the options for
scroll,scrollTo, andscrollBy.First, the
ScrollToOptionsdictionary is deleted, and its properties are converted into subfeatures of the dependent methods.Second, this updates and corrects the data for these different options. While trying to fill out the real values for both Firefox and Safari, I noticed a few discrepancies with the Chrome data as well. This PR fixes them using the following commit/bug data:
Additionally, this removes the IE and Edge partial implementation block on
api.Window.scrollBydescribing that onlyscrollBy(x, y)is supported. This is referring to the lack of support for theoptionsparameter, which is already taken care of by the subfeature.