Safari TP 132, 133, 134 and 135 additions#12439
Merged
Conversation
github-actions
bot
added
data:api
lukewarlow
force-pushed
the
safari-tp-132
branch
from
471897a to
ba1a2b5
Compare
queengooborg
removed
infra
github-actions
bot
added
the
data:http
Contributor
Author
|
#12663 - Filed an issue for the linter issue |
lukewarlow
force-pushed
the
safari-tp-132
branch
from
0e1bdcc to
446924f
Compare
lukewarlow
force-pushed
the
safari-tp-132
branch
from
446924f to
d18558b
Compare
Contributor
|
@lukewarlow is this something you want to revisit in light of #12673 being merged? |
Contributor
Author
Rebased it earlier so should be working and ready for review now 😄 |
lukewarlow
changed the title
github-actions
bot
added
the
data:html
lukewarlow
force-pushed
the
safari-tp-132
branch
from
8d75146 to
0e0fdde
Compare
lukewarlow
commented
Oct 27, 2021
| }, | ||
| "safari": { | ||
| "version_added": false | ||
| "version_added": true |
Contributor
Author
There was a problem hiding this comment.
See #12668, I've verified it's added as of at least Safari 15 but I have no clue of the true support value so leaving as true for now.
lukewarlow
force-pushed
the
safari-tp-132
branch
from
0e0fdde to
3810df3
Compare
Contributor
Author
|
@ddbeck I've updated this to fix the pipeline, I've also added the additions from Safari TP 134. |
lukewarlow
force-pushed
the
safari-tp-132
branch
from
d8439ea to
f7dfcad
Compare
Contributor
Author
|
@ddbeck is there anything left for me to do before review? |
lukewarlow
force-pushed
the
safari-tp-132
branch
4 times, most recently
from
8f0ac3f to
3bb2f22
Compare
lukewarlow
changed the title
lukewarlow
force-pushed
the
safari-tp-132
branch
from
3bb2f22 to
65cb43c
Compare
Contributor
Author
|
I have updated this MR to include 132, 133, 134 and 135 changes. It would be good to get reviewed soon so as to avoid conflicts from the large number of files changed. |
This was referenced Nov 15, 2021
ddbeck
requested changes
Nov 30, 2021
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Thanks for your patience while I got to this, @lukewarlow. A few suggestions for you, but this is shaping up nicely.
lukewarlow
force-pushed
the
safari-tp-132
branch
from
ab34448 to
5928e5f
Compare
This was referenced Dec 25, 2021
jpmedley
pushed a commit
that referenced
this pull request
Jan 10, 2022
* Set Safari preview support for additions in TP 132, 133, 134 and 135 * Address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Set Safari preview support for additions in TP13, TP133, TP134 and TP135
Test results and supporting details
https://webkit.org/blog/11971/release-notes-for-safari-technology-preview-132/
https://webkit.org/blog/11975/release-notes-for-safari-technology-preview-133/
https://webkit.org/blog/12033/release-notes-for-safari-technology-preview-134/
https://webkit.org/blog/12040/release-notes-for-safari-technology-preview-135/
https://webkit.org/blog/11975/release-notes-for-safari-technology-preview-133/#:~:text=Added%20support%20for%20self-start%2C%20self-end%2C%20start%2C%20end%2C%20left%2C%20and%20right%20values%20in%20positional%20alignment%20(r282267%2C%20r282078%2C%20r281840) - I've ignored this for now as the existing support data seems to be rather dubious and needs more investigating.
Closes #13301