Skip to content

Comments

Remove BasicCard[Request/Response] dictionaries from BCD#12367

Merged
queengooborg merged 1 commit intomdn:mainfrom
queengooborg:api/BasicCard
Oct 9, 2021
Merged

Remove BasicCard[Request/Response] dictionaries from BCD#12367
queengooborg merged 1 commit intomdn:mainfrom
queengooborg:api/BasicCard

Conversation

@queengooborg
Copy link
Contributor

This PR removes both the BasicCardRequest and BasicCardResponse dictionaries from BCD.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 13, 2021
@foolip
Copy link
Contributor

foolip commented Sep 13, 2021

Is any MDN cleanup needed for these?

@queengooborg queengooborg added needs content update This PR needs a corresponding update to mdn/content to update the documentation needs-release-note 📰 labels Sep 13, 2021
@queengooborg
Copy link
Contributor Author

Thought I tagged this PR, oops -- some content work is needed for this, yes!

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but the content changes should land first.

@queengooborg queengooborg self-assigned this Sep 21, 2021
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 9, 2021
@queengooborg
Copy link
Contributor Author

Looks like the content updates have been made in mdn/content#9212 so this is ready to go!

@queengooborg queengooborg merged commit 7af777a into mdn:main Oct 9, 2021
@queengooborg queengooborg deleted the api/BasicCard branch October 9, 2021 11:52
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 12, 2021
ddbeck added a commit that referenced this pull request Oct 12, 2021
* Bump version to v4.0.6

* Add release note for #12094

* Add release note for #12367

* Add release note for #12462

* Add release note for #12490

* Add release note for #12565

* Add release note for #12632

* Add release note for #12638

* Add release note for #12639

* Add release note for #12703

* Add release note for #12718

* Add release note for #12723

* Add release note for #12768

* Add release note for #12770

* Add release note for #12772

* Add release note for #12794

* Add release note for #12796

* Add release note for #12813

* Add stats and hoist known issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants