Merged
Conversation
github-actions
bot
added
dependencies
ddbeck
commented
Sep 2, 2021
Contributor
Author
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
Two minor suggestions
RELEASE_NOTES.md
Outdated
|
|
||
| ### WindowOrWorkerGlobalScope removal | ||
|
|
||
| To no longer expose mixins, the following features have been moved from `api.WindowOrWorkerGlobalScope` (or `api.Window` for two cases) to the global `api.*` namespace. The features' worker support is now indicated using `worker_support` sub-features. |
Contributor
Author
There was a problem hiding this comment.
I usually link to the PR, for details, background, etc. Something like this?
Suggested change
| To no longer expose mixins, the following features have been moved from `api.WindowOrWorkerGlobalScope` (or `api.Window` for two cases) to the global `api.*` namespace. The features' worker support is now indicated using `worker_support` sub-features. | |
| To no longer expose mixins, the following features have been moved from `api.WindowOrWorkerGlobalScope` (or `api.Window` for two cases) to the global `api.*` namespace. The features' worker support is now indicated using `worker_support` sub-features. ([#XYZ](https://github.com/…)) |
Elchi3
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Florian:
Publishing docs
Useful npm scripts:
npm run release-pullsnpm run release-statsIf you've got the GitHub CLI (
gh) andjq, you can diff features added/removed by a given (merged) PR:$ node scripts/diff-features.js $(gh pr view --json mergeCommit --jq '.mergeCommit.oid' PULL_REQUEST_URL)Example (which still needs a release note):
$ node scripts/diff-features.js $(gh pr view --json mergeCommit --jq '.mergeCommit.oid' https://github.com/mdn/browser-compat-data/pull/11518)Find placeholders by searching the release notes file for
TK.