Remove Headers.getAll() as irrelevant#12166
Merged
Conversation
- Mirrored for Samsung Internet - Tested manually for Edge (never supported)
ddbeck
added
needs-release-note 📰
needs content update
github-actions
bot
added
the
data:api
Contributor
Author
|
The diff here is a little hard to read. You might want to step through the commits to follow the changes more easily. |
Elchi3
approved these changes
Aug 25, 2021
ddbeck
added a commit
to ddbeck/mdn-content
that referenced
this pull request
Aug 25, 2021
Content counterpart to mdn/browser-compat-data#12166
Contributor
Author
|
Thanks for the reviews. There's now a content PR for this (mdn/content#8284). Merging! |
ddbeck
removed
the
needs content update
teoli2003
pushed a commit
to mdn/content
that referenced
this pull request
Aug 25, 2021
Content counterpart to mdn/browser-compat-data#12166
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Aug 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
api.Headers.getAllas irrelevantgetAllfrom notes ongetgetdataTest results and supporting details
With manual testing, I found that Edge never supported
getAll, clearing it for removal as irrelevant (removed from all other browsers over two years ago). In the course of investigation, I also confirmed the historic behavior ofgetand updated the notes accordingly.Finally, to support content removals on MDN, I scrubbed mentions of
getAllfrom the notes forget.Related issues
I was inspired to investigate this by #12157.