Skip to content

Remove irrelevant api.Window.beforeunload_event.custom_text_support feature#11753

Merged
ddbeck merged 1 commit intomdn:mainfrom
queengooborg:api/Window/beforeunload_event/custom_text_support/removal
Jul 28, 2021
Merged

Remove irrelevant api.Window.beforeunload_event.custom_text_support feature#11753
ddbeck merged 1 commit intomdn:mainfrom
queengooborg:api/Window/beforeunload_event/custom_text_support/removal

Conversation

@queengooborg
Copy link
Contributor

This PR removes the irrelevant beforeunload_event.custom_text_support member of the Window API as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v3.2.2), even if the current BCD suggests support.

…eature

This PR removes the irrelevant `beforeunload_event.custom_text_support` member of the `Window` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.2), even if the current BCD suggests support.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Jul 25, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 25, 2021
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 25, 2021
@ddbeck
Copy link
Contributor

ddbeck commented Jul 27, 2021

@vinyldarkscratch can you link to the content PR for this?

@queengooborg
Copy link
Contributor Author

There is actually no mention of this subfeature anywhere within the MDN page, so there is no need for a content PR!

@ddbeck
Copy link
Contributor

ddbeck commented Jul 28, 2021

I don't think that's right, or I've badly misunderstood the page and this feature. From the reference page:

Some browsers used to display the returned string in the confirmation dialog, enabling the event handler to display a custom message to the user. However, this is deprecated and no longer supported in most browsers.

@ddbeck ddbeck added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 28, 2021
@queengooborg
Copy link
Contributor Author

queengooborg commented Jul 28, 2021

Wow, that's super embarrassing -- I legitimately have glossed over that paragraph both times I checked the page (and I thought I did a search for "custom" before, but I guess not). Eheh...whoops! A content PR has now been created, and merged just as quickly!

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 28, 2021
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vinyldarkscratch!

And I hope it wasn't too embarrassing. Honestly, it's a good thing that "reading every word" (or even writing every word) is not a job requirement for being a tech writer, or I'd have a very different career. 😅

@ddbeck ddbeck merged commit 50a95f2 into mdn:main Jul 28, 2021
@queengooborg queengooborg deleted the api/Window/beforeunload_event/custom_text_support/removal branch July 28, 2021 11:47
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 28, 2021
ddbeck added a commit that referenced this pull request Jul 29, 2021
* Bump version to v3.3.13

* Add release note for #11717

* Add release note for #11753

* Add release note for #11459

* Add release note for #11720

* Add release note for #11722

* Add release note for #11721

* Add release note for #11763

* Add release note for #10623

* Add release note for #11000

* Add stats and release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants