Conversation
github-actions
bot
added
the
data:api
Contributor
|
Per https://html.spec.whatwg.org/multipage/obsolete.html#htmlframesetelement this interface does include the WindowEventHandlers mixin, so this isn't all fiction. I'm not sure we should add all of those entries though... @ddbeck for thoughts. |
ddbeck
approved these changes
Jul 22, 2021
Contributor
ddbeck
left a comment
ddbeck
left a comment
There was a problem hiding this comment.
We probably should have the mixin-originating features too. If you want to make that happen, then great, but if you'd rather open an issue saying that it ought to be done eventually and merge this as-is, I'm fine with that too.
Contributor
Author
|
Since we still need to demix the |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 29, 2021
ddbeck
added a commit
that referenced
this pull request
Jul 29, 2021
* Bump version to v3.3.13 * Add release note for #11717 * Add release note for #11753 * Add release note for #11459 * Add release note for #11720 * Add release note for #11722 * Add release note for #11721 * Add release note for #11763 * Add release note for #10623 * Add release note for #11000 * Add stats and release date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes api.HTMLFrameSetElement.event_handlers from our data. Since the API doesn't define its own event handlers as the MDN article states (and I question whether this API actually has an
onstorageevent handler), there's no reason to have this feature around.