Add accepts_flags to the browsers schema as an optional hint#11286
Merged
Add accepts_flags to the browsers schema as an optional hint#11286
accepts_flags to the browsers schema as an optional hint#11286Conversation
github-actions
bot
added
data:browsers
ddbeck
added
the
not ready
Contributor
Author
|
(Flagged as not ready, so we don't merge it before the next breaking release, likely to take place in July.) |
queengooborg
approved these changes
Jul 1, 2021
Contributor
queengooborg
left a comment
queengooborg
left a comment
There was a problem hiding this comment.
I love this approach as well, so much cleaner than just putting the data into a linter, allowing for our consumers to easily utilize the data too!
ddbeck
removed
the
not ready
Contributor
Author
|
Since this is approved and I'm planning for the next release (Thursday) to be v4.0.0, I'm merging this now. |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Aug 17, 2021
ddbeck
added a commit
that referenced
this pull request
Aug 19, 2021
* Bump version to v4.0.0 * Add release note for #11234 * Bump known issues * Add release note for #11760 * Add release note for #11286 * Add release note for #9830 * Add release note for #10334 * Add v4.0.0 highlights to release notes * Add release note for #10753 * Revise description of `accepts_flags` hint * Add release note for #11961 * Add release note for #12059 * Add stats
Contributor
|
I'm opting to remove the release-level property in #15990 because of a lack of implementation. We've only been using the browser-level version in practice and in linting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes an addition to the schema,
accepts_flagsfor both browsers as a whole and individual releases. This is me trying to having it both ways: providing an easy option (per-browser) for easy cases and a harder option (per-release) for harder cases.I defined this part of the schema as an optional hint, rather than to trying to use it to drive the linter immediately or do anything more restrictive. I'm proposing it in this shallow state now, so that we can roll it into the next breaking release (which we require for schema changes).
Related issues
#10616